feat(plasma-new-hope/web/b2c): overlay component #1033

TitanKuzmich · 2024-02-06T13:23:18Z

Overlay

добавлен в новой архитектуре
добавлен в поставку для plasma-{b2c/web}
написаны тесты и документация
интегрирован в компоненты Toast, Modal

What/why changed

Добавлен компонент Overlay.

Будет использоваться в всплывающих компонентах.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

Salute-Eva · 2024-02-06T13:26:14Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1033/

Salute-Eva · 2024-02-06T13:48:38Z

Documentation preview deployed!

github-actions · 2024-02-06T13:51:04Z

⚡ Component performance testing

Result: 🟢 OK

neretin-trike · 2024-02-08T09:05:34Z

допиши пожалуйста в описании к PR (до What/why changed), в каких компонентах в итоге добавил компонент Overlay

Salute-Eva · 2024-02-08T10:10:42Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1033/

Salute-Eva · 2024-02-08T10:23:55Z

Documentation preview deployed!

github-actions · 2024-02-08T10:34:56Z

⚡ Component performance testing

Result: 🟢 OK

neretin-trike · 2024-02-08T17:56:55Z

packages/plasma-web/src/index.ts

@@ -18,6 +18,7 @@ export * from './components/List';
 export * from './components/Modal';
 export * from './components/ModalBase';
 export * from './components/Notification';
+export * from './components/Overlay';


а мы точно хотим его в наружу отдавать? По идее это же техническая штука, которую мы в своих компонентах используем 🤔

В MUI поставляется как отдельный компонент https://mui.com/material-ui/react-backdrop/
Мне кажется, что может пригодиться как отдельный компонент

я тоже думал, что это как отдельный компонент, который в поставку входить будет

neretin-trike · 2024-02-08T18:00:04Z

packages/plasma-web/src/components/Overlay/Overlay.stories.tsx

+
+import { Overlay } from '.';
+
+const onOverlayClick = action('onOverlayClick');


колбэк отрабатывает, но при включенном свойстве closeOnOverlayClick не закрывает сам оверлей

возможно просто нужно пример поправить

Логически неправильно назвал проп. Должно быть isClickable

а получилось в итоге поправить? У меня пока всё ещё не закрывается

Проп переименуется в isClickable, чтобы не было путаницы

а этот колбэк не хотим оставить? Вроде же полезная штука может быть

Колбэк остается, просто логика в нем прописывается пользователем

packages/plasma-new-hope/src/components/Overlay/Overlay.types.ts

github-actions · 2024-02-09T08:20:02Z

⚡ Component performance testing

Result: 🟢 OK

packages/plasma-new-hope/src/components/Overlay/Overlay.types.ts

Salute-Eva · 2024-02-12T09:10:23Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1033/

Salute-Eva · 2024-02-12T09:22:14Z

Documentation preview deployed!

github-actions · 2024-02-12T09:37:46Z

⚡ Component performance testing

Result: 🟢 OK

Salute-Eva · 2024-02-12T10:03:24Z

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

Salute-Eva · 2024-02-12T10:03:27Z

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

Salute-Eva · 2024-02-12T10:03:30Z

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

Salute-Eva · 2024-02-12T10:03:33Z

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

Salute-Eva · 2024-02-12T10:03:36Z

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

TitanKuzmich added the plasma-components label Feb 6, 2024

TitanKuzmich self-assigned this Feb 6, 2024

TitanKuzmich requested review from Yeti-or, neretin-trike, Yakutoc and kayman233 as code owners February 6, 2024 13:23

TitanKuzmich temporarily deployed to internal February 6, 2024 13:23 — with GitHub Actions Inactive

TitanKuzmich removed request for Yeti-or and Yakutoc February 6, 2024 13:52

TitanKuzmich force-pushed the plasma-1764/overlay-component branch from 93e82ec to e8617d8 Compare February 8, 2024 10:07

TitanKuzmich temporarily deployed to internal February 8, 2024 10:07 — with GitHub Actions Inactive

neretin-trike reviewed Feb 8, 2024

View reviewed changes

packages/plasma-new-hope/src/components/Overlay/Overlay.types.ts Show resolved Hide resolved

TitanKuzmich requested a review from neretin-trike February 9, 2024 07:28

TitanKuzmich force-pushed the plasma-1764/overlay-component branch from e8617d8 to dfb9116 Compare February 9, 2024 07:28

TitanKuzmich temporarily deployed to internal February 9, 2024 07:28 — with GitHub Actions Inactive

TitanKuzmich requested a review from Yakutoc February 9, 2024 10:06

kayman233 approved these changes Feb 9, 2024

View reviewed changes

packages/plasma-new-hope/src/components/Overlay/Overlay.types.ts Outdated Show resolved Hide resolved

TitanKuzmich added 5 commits February 10, 2024 01:34

feat(plasma-new-hope): add Overlay component

26fd9b0

test(plasma-b2c/web): add Overlay snapshots

05e32c8

docs(plasma-web/b2c): regenerate api docs

a364fdb

docs(plasma-web-docs): add Overlay docs

e2e8027

feat(plasma-web/b2c): add Overlay component

f7dcdd9

neretin-trike approved these changes Feb 12, 2024

View reviewed changes

TitanKuzmich force-pushed the plasma-1764/overlay-component branch from eaf553c to f7dcdd9 Compare February 12, 2024 09:07

TitanKuzmich temporarily deployed to internal February 12, 2024 09:07 — with GitHub Actions Inactive

TitanKuzmich added this pull request to the merge queue Feb 12, 2024

Merged via the queue into dev with commit cf4b84b Feb 12, 2024
25 checks passed

TitanKuzmich deleted the plasma-1764/overlay-component branch February 12, 2024 09:48

Salute-Eva added the prerelease label Feb 12, 2024

Salute-Eva mentioned this pull request Feb 14, 2024

Release by 14.02.2024 #1047

Merged

This was referenced Jul 24, 2024

Release by 24.07.2024 #1316

Closed

Release by 24.07.2024 #1317

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(plasma-new-hope/web/b2c): overlay component #1033

feat(plasma-new-hope/web/b2c): overlay component #1033

TitanKuzmich commented Feb 6, 2024 •

edited by Yakutoc

Loading

Salute-Eva commented Feb 6, 2024

Salute-Eva commented Feb 6, 2024

github-actions bot commented Feb 6, 2024

neretin-trike commented Feb 8, 2024

Salute-Eva commented Feb 8, 2024

Salute-Eva commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

neretin-trike Feb 8, 2024

TitanKuzmich Feb 9, 2024

kayman233 Feb 9, 2024

neretin-trike Feb 8, 2024

neretin-trike Feb 8, 2024

TitanKuzmich Feb 9, 2024

neretin-trike Feb 9, 2024

TitanKuzmich Feb 9, 2024 •

edited

Loading

neretin-trike Feb 9, 2024

TitanKuzmich Feb 9, 2024 •

edited

Loading

github-actions bot commented Feb 9, 2024

Salute-Eva commented Feb 12, 2024

Salute-Eva commented Feb 12, 2024

github-actions bot commented Feb 12, 2024

Salute-Eva commented Feb 12, 2024

Salute-Eva commented Feb 12, 2024

Salute-Eva commented Feb 12, 2024

Salute-Eva commented Feb 12, 2024

Salute-Eva commented Feb 12, 2024


		import { Overlay } from '.';

		const onOverlayClick = action('onOverlayClick');

feat(plasma-new-hope/web/b2c): overlay component #1033

feat(plasma-new-hope/web/b2c): overlay component #1033

Conversation

TitanKuzmich commented Feb 6, 2024 • edited by Yakutoc Loading

Overlay

What/why changed

Salute-Eva commented Feb 6, 2024

Salute-Eva commented Feb 6, 2024

github-actions bot commented Feb 6, 2024

⚡ Component performance testing

neretin-trike commented Feb 8, 2024

Salute-Eva commented Feb 8, 2024

Salute-Eva commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

⚡ Component performance testing

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TitanKuzmich Feb 9, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TitanKuzmich Feb 9, 2024 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Feb 9, 2024

⚡ Component performance testing

Salute-Eva commented Feb 12, 2024

Salute-Eva commented Feb 12, 2024

github-actions bot commented Feb 12, 2024

⚡ Component performance testing

Salute-Eva commented Feb 12, 2024

Salute-Eva commented Feb 12, 2024

Salute-Eva commented Feb 12, 2024

Salute-Eva commented Feb 12, 2024

Salute-Eva commented Feb 12, 2024

TitanKuzmich commented Feb 6, 2024 •

edited by Yakutoc

Loading

TitanKuzmich Feb 9, 2024 •

edited

Loading

TitanKuzmich Feb 9, 2024 •

edited

Loading