Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plasma-new-hope): add button group component #1061

Merged
merged 13 commits into from
Feb 28, 2024
Merged

feat(plasma-new-hope): add button group component #1061

merged 13 commits into from
Feb 28, 2024

Conversation

TitanKuzmich
Copy link
Contributor

@TitanKuzmich TitanKuzmich commented Feb 20, 2024 •
edited by Yakutoc
Loading

ButtonGroup

  • добавлен новый компонент и тесты с документацией
  • исправлена структура файлов для Spiner
  • добавлен компонент Button в поставку в plasma-{b2c,web}
  • обновлена документация для Button
  • обновлены тесты зависящие от Button

What/why changed

Добавлен новый компонент ButtonGroup.

Button доработан и перенесен в web/b2c, так как без этого ButtonGroup не имел бы смысла.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@TitanKuzmich TitanKuzmich self-assigned this Feb 20, 2024
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1061/

@TitanKuzmich TitanKuzmich force-pushed the plasma-2122/button-group-component branch from 725e0b9 to 87e5f9b Compare February 20, 2024 09:51
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1061/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-1061/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-1061/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-1061/web-storybook/
new-hope storybook: http://plasma.sberdevices.ru/pr/pr-1061/new-hope-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-1061/asdk-storybook/
caldera storybook: http://plasma.sberdevices.ru/pr/pr-1061/caldera-storybook/
caldera-online storybook: http://plasma.sberdevices.ru/pr/pr-1061/caldera-online-storybook/

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich force-pushed the plasma-2122/button-group-component branch from 87e5f9b to 394d3a4 Compare February 20, 2024 10:30
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1061/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-1061/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-1061/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-1061/web-storybook/
new-hope storybook: http://plasma.sberdevices.ru/pr/pr-1061/new-hope-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-1061/asdk-storybook/
caldera storybook: http://plasma.sberdevices.ru/pr/pr-1061/caldera-storybook/
caldera-online storybook: http://plasma.sberdevices.ru/pr/pr-1061/caldera-online-storybook/

@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1061/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-1061/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-1061/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-1061/web-storybook/
new-hope storybook: http://plasma.sberdevices.ru/pr/pr-1061/new-hope-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-1061/asdk-storybook/
caldera storybook: http://plasma.sberdevices.ru/pr/pr-1061/caldera-storybook/
caldera-online storybook: http://plasma.sberdevices.ru/pr/pr-1061/caldera-online-storybook/

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich force-pushed the plasma-2122/button-group-component branch from 68d2a34 to eba2284 Compare February 28, 2024 06:17
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1061/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-1061/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-1061/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-1061/web-storybook/
new-hope storybook: http://plasma.sberdevices.ru/pr/pr-1061/new-hope-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-1061/asdk-storybook/
caldera storybook: http://plasma.sberdevices.ru/pr/pr-1061/caldera-storybook/
caldera-online storybook: http://plasma.sberdevices.ru/pr/pr-1061/caldera-online-storybook/

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich added this pull request to the merge queue Feb 28, 2024
Merged via the queue into dev with commit 0e79f2e Feb 28, 2024
22 of 23 checks passed
@TitanKuzmich TitanKuzmich deleted the plasma-2122/button-group-component branch February 28, 2024 06:58
@Salute-Eva Salute-Eva mentioned this pull request Feb 29, 2024
Merged
This was referenced Jul 24, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neretin-trike neretin-trike neretin-trike approved these changes

@shuga2704 shuga2704 shuga2704 approved these changes

@luizasok luizasok luizasok approved these changes

@Yeti-or Yeti-or Awaiting requested review from Yeti-or Yeti-or is a code owner

Assignees

@TitanKuzmich TitanKuzmich

Labels
plasma-components
Projects
Plasma
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TitanKuzmich @Salute-Eva @neretin-trike @shuga2704 @luizasok