Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plasma-icons: build-time generate Icon components #1101

Merged
merged 3 commits into from
Mar 12, 2024
Merged

plasma-icons: build-time generate Icon components #1101

merged 3 commits into from
Mar 12, 2024

Conversation

kayman233
Copy link
Contributor

@kayman233 kayman233 commented Mar 6, 2024 •
edited by Salute-Eva
Loading

Icons

  • Добавлена генерация компонентов иконок на основе svg во время билда
  • Соотвественно удалены компоненты и их ассеты из гита

What/why changed

Теперь компоненты генерируются с помощью скрипта generateReactComponents в соответствующей новой папке со скриптами. Также для более удобного взаимодействия, перенесены старые иконки в отдельную папку

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@kayman233 kayman233 force-pushed the icons-svg-to-react branch from 5e595f1 to fda206a Compare March 6, 2024 16:08
@kayman233 kayman233 force-pushed the icons-svg-to-react branch from fda206a to ccd86c0 Compare March 6, 2024 16:20
@kayman233 kayman233 changed the base branch from icons-svg to dev March 6, 2024 16:20
@kayman233 kayman233 changed the title plasma-icons: test plasma-icons: generating Icon components on build Mar 6, 2024
@kayman233 kayman233 force-pushed the icons-svg-to-react branch from ccd86c0 to 971119a Compare March 6, 2024 16:28
@kayman233 kayman233 changed the title plasma-icons: generating Icon components on build plasma-icons: build-time generate Icon components Mar 6, 2024
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1101/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-1101/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-1101/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-1101/web-storybook/
ui storybook: http://plasma.sberdevices.ru/pr/pr-1101/ui-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-1101/asdk-storybook/
sdds-serv storybook: http://plasma.sberdevices.ru/pr/pr-1101/sdds-serv-storybook/

@kayman233 kayman233 marked this pull request as ready for review March 6, 2024 16:54
@kayman233 kayman233 requested a review from TitanKuzmich March 6, 2024 16:55
@kayman233 kayman233 force-pushed the icons-svg-to-react branch from 971119a to 6c9fc8d Compare March 12, 2024 07:33
@kayman233 kayman233 requested a review from shuga2704 March 12, 2024 07:33
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1101/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-1101/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-1101/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-1101/web-storybook/
ui storybook: http://plasma.sberdevices.ru/pr/pr-1101/ui-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-1101/asdk-storybook/
sdds-serv storybook: http://plasma.sberdevices.ru/pr/pr-1101/sdds-serv-storybook/

@kayman233 kayman233 force-pushed the icons-svg-to-react branch from 6c9fc8d to b100d4b Compare March 12, 2024 08:34
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1101/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-1101/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-1101/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-1101/web-storybook/
ui storybook: http://plasma.sberdevices.ru/pr/pr-1101/ui-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-1101/asdk-storybook/
sdds-serv storybook: http://plasma.sberdevices.ru/pr/pr-1101/sdds-serv-storybook/

@kayman233 kayman233 force-pushed the icons-svg-to-react branch from b100d4b to bbb2327 Compare March 12, 2024 16:07
@kayman233 kayman233 enabled auto-merge March 12, 2024 16:08
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1101/

@kayman233 kayman233 added this pull request to the merge queue Mar 12, 2024
@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-1101/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-1101/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-1101/web-storybook/
ui storybook: http://plasma.sberdevices.ru/pr/pr-1101/ui-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-1101/asdk-storybook/
sdds-serv storybook: http://plasma.sberdevices.ru/pr/pr-1101/sdds-serv-storybook/

Merged via the queue into dev with commit ce00372 Mar 12, 2024
25 checks passed
@kayman233 kayman233 deleted the icons-svg-to-react branch March 12, 2024 16:36
@Salute-Eva Salute-Eva mentioned this pull request Mar 13, 2024
Merged
This was referenced Jul 24, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TitanKuzmich TitanKuzmich TitanKuzmich approved these changes

@neretin-trike neretin-trike neretin-trike approved these changes

@Yeti-or Yeti-or Yeti-or approved these changes

@Yakutoc Yakutoc Awaiting requested review from Yakutoc Yakutoc is a code owner

@shuga2704 shuga2704 Awaiting requested review from shuga2704 shuga2704 is a code owner

Assignees
No one assigned
Labels
plasma-icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kayman233 @Salute-Eva @Yeti-or @neretin-trike @TitanKuzmich