Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plasma-icons: script to generate android icons #1109

Merged
merged 1 commit into from
Mar 14, 2024
Merged

plasma-icons: script to generate android icons #1109

merged 1 commit into from
Mar 14, 2024

Conversation

kayman233
Copy link
Contributor

@kayman233 kayman233 commented Mar 12, 2024 •
edited by Salute-Eva
Loading

Icons

  • Добавлен скрипт генерации иконок под android на основе svg
  • Обновлена инструкция по добавлению иконок

What/why changed

Теперь можно генерировать zip архив с иконками в формате .xml для android, которые в дальнейшем будут использоваться и публиковаться в отдельном пакете.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@kayman233 kayman233 changed the title Icons svg to android plasma-icons: script to generate android icons Mar 12, 2024
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1109/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-1109/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-1109/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-1109/web-storybook/
ui storybook: http://plasma.sberdevices.ru/pr/pr-1109/ui-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-1109/asdk-storybook/
sdds-serv storybook: http://plasma.sberdevices.ru/pr/pr-1109/sdds-serv-storybook/

@kayman233 kayman233 force-pushed the icons-svg-to-android branch from 5beed29 to bbb7308 Compare March 13, 2024 07:03
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1109/

@kayman233 kayman233 marked this pull request as ready for review March 13, 2024 07:07
@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-1109/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-1109/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-1109/web-storybook/
ui storybook: http://plasma.sberdevices.ru/pr/pr-1109/ui-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-1109/asdk-storybook/
sdds-serv storybook: http://plasma.sberdevices.ru/pr/pr-1109/sdds-serv-storybook/

@kayman233 kayman233 force-pushed the icons-svg-to-android branch from bbb7308 to 7a41149 Compare March 14, 2024 08:31
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1109/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-1109/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-1109/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-1109/web-storybook/
ui storybook: http://plasma.sberdevices.ru/pr/pr-1109/ui-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-1109/asdk-storybook/
sdds-serv storybook: http://plasma.sberdevices.ru/pr/pr-1109/sdds-serv-storybook/

@kayman233 kayman233 added this pull request to the merge queue Mar 14, 2024
Merged via the queue into dev with commit 9c12e2e Mar 14, 2024
25 checks passed
@kayman233 kayman233 deleted the icons-svg-to-android branch March 14, 2024 09:04
@Salute-Eva Salute-Eva mentioned this pull request Mar 27, 2024
Merged
This was referenced Jul 24, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malilex malilex malilex approved these changes

@neretin-trike neretin-trike neretin-trike approved these changes

@TitanKuzmich TitanKuzmich Awaiting requested review from TitanKuzmich TitanKuzmich is a code owner

@Yeti-or Yeti-or Awaiting requested review from Yeti-or Yeti-or is a code owner

@Yakutoc Yakutoc Awaiting requested review from Yakutoc Yakutoc is a code owner

Assignees
No one assigned
Labels
plasma-icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kayman233 @Salute-Eva @neretin-trike @malilex