Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove scale tokens from Button & ButtonGroup #1110

Merged
merged 1 commit into from
Mar 12, 2024
Merged

feat: remove scale tokens from Button & ButtonGroup #1110

merged 1 commit into from
Mar 12, 2024

Conversation

TitanKuzmich
Copy link
Contributor

@TitanKuzmich TitanKuzmich commented Mar 12, 2024 •
edited by Yakutoc
Loading

Button

  • удалены токены scale из кнопки и группы кнопок в пакетах plasma-{b2c, web, sdds-serv}, caldera/-online
  • удалены токены scale из example для plasma-new-hope

What/why changed

Scale ошибочно применялся к кнопке при hover и нажатии, поэтому были удалены токены, которые задавали значение scale.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@TitanKuzmich TitanKuzmich self-assigned this Mar 12, 2024
@TitanKuzmich TitanKuzmich requested review from shuga2704 and removed request for Yeti-or and Yakutoc March 12, 2024 12:57
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1110/

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-1110/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-1110/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-1110/web-storybook/
new-hope storybook: http://plasma.sberdevices.ru/pr/pr-1110/new-hope-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-1110/asdk-storybook/
caldera storybook: http://plasma.sberdevices.ru/pr/pr-1110/caldera-storybook/
caldera-online storybook: http://plasma.sberdevices.ru/pr/pr-1110/caldera-online-storybook/
sdds-serv storybook: http://plasma.sberdevices.ru/pr/pr-1110/sdds-serv-storybook/

@TitanKuzmich TitanKuzmich force-pushed the plasma-2587/remove-scale-from-button branch from b09f052 to de42f57 Compare March 12, 2024 19:06
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1110/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-1110/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-1110/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-1110/web-storybook/
new-hope storybook: http://plasma.sberdevices.ru/pr/pr-1110/new-hope-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-1110/asdk-storybook/
caldera storybook: http://plasma.sberdevices.ru/pr/pr-1110/caldera-storybook/
caldera-online storybook: http://plasma.sberdevices.ru/pr/pr-1110/caldera-online-storybook/
sdds-serv storybook: http://plasma.sberdevices.ru/pr/pr-1110/sdds-serv-storybook/

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich added this pull request to the merge queue Mar 12, 2024
Merged via the queue into dev with commit 733fa9c Mar 12, 2024
23 checks passed
@TitanKuzmich TitanKuzmich deleted the plasma-2587/remove-scale-from-button branch March 12, 2024 19:37
@Salute-Eva Salute-Eva mentioned this pull request Mar 13, 2024
Merged
This was referenced Jul 24, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuga2704 shuga2704 shuga2704 approved these changes

@kayman233 kayman233 kayman233 approved these changes

@neretin-trike neretin-trike neretin-trike approved these changes

Assignees

@TitanKuzmich TitanKuzmich

Labels
plasma-components
Projects
Plasma
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TitanKuzmich @Salute-Eva @neretin-trike @kayman233 @shuga2704