Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix args for Image stories #1119

Merged
merged 2 commits into from
Mar 18, 2024
Merged

fix: fix args for Image stories #1119

merged 2 commits into from
Mar 18, 2024

Conversation

TitanKuzmich
Copy link
Contributor

@TitanKuzmich TitanKuzmich commented Mar 14, 2024 •
edited by Yakutoc
Loading

Image

  • поправлена передача props в Image.stories

What/why changed

Поправлена передача пропсов в Image сторях.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@TitanKuzmich TitanKuzmich requested review from shuga2704 and removed request for Yeti-or, Yakutoc and kayman233 March 14, 2024 13:07
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1119/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-1119/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-1119/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-1119/web-storybook/
sdds-serv storybook: http://plasma.sberdevices.ru/pr/pr-1119/sdds-serv-storybook/

@TitanKuzmich TitanKuzmich force-pushed the plasma-2602/fix-image-story-props branch from 1261cec to f6a24f8 Compare March 18, 2024 08:49
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1119/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-1119/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-1119/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-1119/web-storybook/
new-hope storybook: http://plasma.sberdevices.ru/pr/pr-1119/new-hope-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-1119/asdk-storybook/
caldera storybook: http://plasma.sberdevices.ru/pr/pr-1119/caldera-storybook/
caldera-online storybook: http://plasma.sberdevices.ru/pr/pr-1119/caldera-online-storybook/
sdds-serv storybook: http://plasma.sberdevices.ru/pr/pr-1119/sdds-serv-storybook/

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich force-pushed the plasma-2602/fix-image-story-props branch from f6a24f8 to 118a03d Compare March 18, 2024 10:21
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1119/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-1119/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-1119/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-1119/web-storybook/
new-hope storybook: http://plasma.sberdevices.ru/pr/pr-1119/new-hope-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-1119/asdk-storybook/
caldera storybook: http://plasma.sberdevices.ru/pr/pr-1119/caldera-storybook/
caldera-online storybook: http://plasma.sberdevices.ru/pr/pr-1119/caldera-online-storybook/
sdds-serv storybook: http://plasma.sberdevices.ru/pr/pr-1119/sdds-serv-storybook/

@TitanKuzmich TitanKuzmich added this pull request to the merge queue Mar 18, 2024
Merged via the queue into dev with commit 45aa6ca Mar 18, 2024
22 of 23 checks passed
@TitanKuzmich TitanKuzmich deleted the plasma-2602/fix-image-story-props branch March 18, 2024 10:54
@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@Salute-Eva Salute-Eva mentioned this pull request Mar 27, 2024
Merged
This was referenced Jul 24, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yeti-or Yeti-or Yeti-or approved these changes

@neretin-trike neretin-trike neretin-trike approved these changes

@shuga2704 shuga2704 Awaiting requested review from shuga2704 shuga2704 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TitanKuzmich @Salute-Eva @Yeti-or @neretin-trike