Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plasma-web,plasma-b2c,plasma-asdk): Replace tokens for background in storybook to new #1139

Merged
merged 1 commit into from
Mar 22, 2024
Merged

fix(plasma-web,plasma-b2c,plasma-asdk): Replace tokens for background in storybook to new #1139

merged 1 commit into from
Mar 22, 2024

Conversation

neretin-trike
Copy link
Collaborator

@neretin-trike neretin-trike commented Mar 21, 2024 •
edited by Yakutoc
Loading

Docs

  • Исправлена ошибка примера путём обновления токенов бэграундов в сторибуке для библиотек plasma-web, plasma-b2c, plasma-asdk.

До:

Screenshot 2024-03-21 at 12 28 41

После:

Screenshot 2024-03-21 at 17 03 31

What/why changed

Сейчас заливка некоторых новых компонент сливаются с фоном storybook

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@neretin-trike neretin-trike added the plasma-docs Improvements or additions to documentation label Mar 21, 2024
@neretin-trike neretin-trike self-assigned this Mar 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1139/

@github-actions GitHub Actions
Copy link
Contributor

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1139/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1139/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1139/b2c-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1139/web-storybook/

Yeti-or
Yeti-or approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@Yeti-or Yeti-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

добавь тогда в описании что это ошибка примера, и как оно теперь выглядит
типа было/стало

@neretin-trike neretin-trike force-pushed the neretinaa/fix-background-tokens-storybook branch from c48ccc7 to 4c04f34 Compare March 21, 2024 11:46
@neretin-trike neretin-trike added this pull request to the merge queue Mar 22, 2024
Merged via the queue into dev with commit c0b863a Mar 22, 2024
24 of 25 checks passed
@neretin-trike neretin-trike deleted the neretinaa/fix-background-tokens-storybook branch March 22, 2024 11:51
@neretin-trike neretin-trike restored the neretinaa/fix-background-tokens-storybook branch March 22, 2024 16:14
@Salute-Eva Salute-Eva mentioned this pull request Mar 27, 2024
Merged
This was referenced Jul 24, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TitanKuzmich TitanKuzmich TitanKuzmich approved these changes

@Yeti-or Yeti-or Yeti-or approved these changes

@Yakutoc Yakutoc Awaiting requested review from Yakutoc Yakutoc is a code owner

@kayman233 kayman233 Awaiting requested review from kayman233

Assignees

@neretin-trike neretin-trike

Labels
plasma-docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neretin-trike @Yeti-or @TitanKuzmich