Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(new-hope): Add cell #1148

Merged
merged 2 commits into from
Apr 3, 2024
Merged

feat(new-hope): Add cell #1148

merged 2 commits into from
Apr 3, 2024

Conversation

iljs
Copy link
Contributor

@iljs iljs commented Mar 26, 2024 •
edited by Salute-Eva
Loading

Cell

  • добавлен в поставку plasma-{web,b2c}

What/why changed

Добавил компонент Cell, который также включает компоненты Textbox, TextTitle, TextSubtitle, TextLabel

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@iljs iljs self-assigned this Mar 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1148/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 26, 2024 •
edited
Loading

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1148/
caldera-online storybook: https://plasma.sberdevices.ru/pr/pr-1148/caldera-online-storybook/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1148/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1148/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1148/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1148/web-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1148/sdds-serv-storybook/

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@iljs iljs requested review from simashova and shuga2704 March 26, 2024 09:16
@iljs iljs force-pushed the feat-cell-component branch from 3e2fe97 to fae08c4 Compare March 26, 2024 14:35
@iljs iljs force-pushed the feat-cell-component branch from fae08c4 to 84e0b2c Compare March 26, 2024 14:37
@TitanKuzmich
Copy link
Contributor

Добавь еще тесты на alignment, без контента справа/слева. Глянь, какие тесты есть в plasma-ui

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@iljs iljs marked this pull request as ready for review March 26, 2024 18:34
@iljs iljs requested a review from TitanKuzmich March 26, 2024 18:34
@iljs iljs force-pushed the feat-cell-component branch from fca5bc8 to d3b65ae Compare April 3, 2024 08:28
@iljs iljs force-pushed the feat-cell-component branch from d3b65ae to 4f9f3d9 Compare April 3, 2024 08:53
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024

⚡ Component performance testing

Result: 🟢 OK

@iljs iljs force-pushed the feat-cell-component branch from 4f9f3d9 to 729d8c5 Compare April 3, 2024 12:40
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024

⚡ Component performance testing

Result: 🟢 OK

@iljs iljs added this pull request to the merge queue Apr 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 3, 2024
@iljs iljs added this pull request to the merge queue Apr 3, 2024
Merged via the queue into dev with commit f40477e Apr 3, 2024
28 checks passed
@iljs iljs deleted the feat-cell-component branch April 3, 2024 13:39
@Salute-Eva Salute-Eva mentioned this pull request Apr 10, 2024
Merged
This was referenced Jul 24, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neretin-trike neretin-trike neretin-trike approved these changes

@TitanKuzmich TitanKuzmich TitanKuzmich approved these changes

@shuga2704 shuga2704 shuga2704 approved these changes

@simashova simashova simashova approved these changes

@Yakutoc Yakutoc Awaiting requested review from Yakutoc Yakutoc is a code owner

Assignees

@iljs iljs

Labels
plasma-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@iljs @TitanKuzmich @Yeti-or @neretin-trike @Yakutoc @shuga2704 @simashova