Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plasma-icons: Add old dir for publish #1149

Merged
merged 1 commit into from
Mar 27, 2024
Merged

plasma-icons: Add old dir for publish #1149

merged 1 commit into from
Mar 27, 2024

Conversation

Yakutoc
Copy link
Collaborator

@Yakutoc Yakutoc commented Mar 26, 2024 •
edited by Salute-Eva
Loading

Icons publish

  • добавлена директория old для обратной совместимости

What/why changed

поломались пути до части иконок, например

Module not found: Can't resolve './old/Icons/IconClockFilled'

или

unhandledRejection Error: Cannot find module './old/Icons/IconApps'
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@Yakutoc Yakutoc self-assigned this Mar 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 26, 2024 •
edited
Loading

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1149/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1149/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1149/b2c-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1149/ui-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1149/web-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1149/sdds-serv-storybook/

@Yakutoc Yakutoc changed the title plasma-icons: Fix build [WIP] plasma-icons: Add old dir for publish Mar 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1149/

@Yakutoc Yakutoc marked this pull request as ready for review March 27, 2024 05:24
@Yakutoc Yakutoc removed the request for review from kayman233 March 27, 2024 05:24
@Yakutoc Yakutoc added this pull request to the merge queue Mar 27, 2024
Merged via the queue into dev with commit 81a1c98 Mar 27, 2024
29 checks passed
@Yakutoc Yakutoc deleted the fix-plasma-icons branch March 27, 2024 07:51
@Salute-Eva Salute-Eva mentioned this pull request Mar 27, 2024
Merged
This was referenced Jul 24, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yeti-or Yeti-or Yeti-or approved these changes

@TitanKuzmich TitanKuzmich TitanKuzmich approved these changes

@neretin-trike neretin-trike Awaiting requested review from neretin-trike neretin-trike is a code owner

Assignees

@Yakutoc Yakutoc

Labels
plasma-icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yakutoc @Yeti-or @TitanKuzmich