Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plasma-new-hope): TextField redesign #1160

Merged
merged 7 commits into from
Apr 10, 2024
Merged

feat(plasma-new-hope): TextField redesign #1160

merged 7 commits into from
Apr 10, 2024

Conversation

TitanKuzmich
Copy link
Contributor

@TitanKuzmich TitanKuzmich commented Apr 3, 2024 •
edited by Yakutoc
Loading

TextField

  • проведен рефакторинг и редизайн
  • обновлены тесты и документация
  • добавлен в поставку в sdds-serv

What/why changed

TextField приведен в соответствие с макетами.

Клавиатурная навигация

  • по нажатию Tab фокусируемся на инпуте
  • если enumeratinType=chip после ввода текста, по нажатию Enter, инпут очистится и появится Chip
  • если введен текст в инпуте по нажатию ArrowLeft или ArrowRight каретка передвигается по тексту
  • при достижении левой границы текста или отсутствии текста в инпуте, при нажатии Backspace удаляем последний Chip, если он есть
  • при достижении левой границы текста или отсутствии текста в инпуте, при нажатии ArrowLeft переключаемся на последний Chip, если он есть
  • при фокусе на Chip работает переключение фокуса на другие Chip по нажатию ArrowLeft, ArrowRight; если же Chip крайний правый, при нажатии ArrowRight фокус переходит на инпут
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@TitanKuzmich TitanKuzmich self-assigned this Apr 3, 2024
@TitanKuzmich TitanKuzmich removed the request for review from Yakutoc April 3, 2024 15:18
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1160/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1160/
caldera-online storybook: https://plasma.sberdevices.ru/pr/pr-1160/caldera-online-storybook/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1160/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1160/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1160/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1160/web-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1160/sdds-serv-storybook/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich requested a review from Irinkv April 4, 2024 07:36
@TitanKuzmich TitanKuzmich force-pushed the plasma-2696/textfield-redesign branch from bade9ef to 5b13ae1 Compare April 4, 2024 09:21
@TitanKuzmich TitanKuzmich force-pushed the plasma-2696/textfield-redesign branch from 5b13ae1 to 2a33376 Compare April 4, 2024 09:49
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich force-pushed the plasma-2696/textfield-redesign branch from 2a33376 to f31f0cb Compare April 4, 2024 13:18
@TitanKuzmich TitanKuzmich force-pushed the plasma-2696/textfield-redesign branch from 5349c84 to 164847e Compare April 9, 2024 14:09
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich force-pushed the plasma-2696/textfield-redesign branch from 164847e to f4cfbf9 Compare April 10, 2024 06:40
@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich added this pull request to the merge queue Apr 10, 2024
Merged via the queue into dev with commit 54aa25e Apr 10, 2024
28 checks passed
@TitanKuzmich TitanKuzmich deleted the plasma-2696/textfield-redesign branch April 10, 2024 07:27
@Salute-Eva Salute-Eva mentioned this pull request Apr 10, 2024
Merged
This was referenced Jul 24, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Irinkv Irinkv Irinkv approved these changes

@shuga2704 shuga2704 shuga2704 approved these changes

@neretin-trike neretin-trike neretin-trike approved these changes

@Yeti-or Yeti-or Awaiting requested review from Yeti-or Yeti-or is a code owner

Assignees

@TitanKuzmich TitanKuzmich

Labels
plasma-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TitanKuzmich @neretin-trike @shuga2704 @Irinkv