Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plasma-new-hope(avatar): Refactoring + a11y #1180

Merged
merged 5 commits into from
Apr 19, 2024
Merged

plasma-new-hope(avatar): Refactoring + a11y #1180

merged 5 commits into from
Apr 19, 2024

Conversation

Yakutoc
Copy link
Collaborator

@Yakutoc Yakutoc commented Apr 15, 2024 •
edited by Salute-Eva
Loading

Avatar

  • добавлен aria-label
  • расширены примеры с доступностью

What/why changed

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@Yakutoc Yakutoc added the a11y label Apr 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1180/

@github-actions GitHub Actions
Copy link
Contributor

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1180/
caldera-online storybook: https://plasma.sberdevices.ru/pr/pr-1180/caldera-online-storybook/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1180/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1180/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1180/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1180/web-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1180/sdds-serv-storybook/

@Yakutoc Yakutoc changed the title a11y(avatar): Refactoring a11y plasma-new-hope(avatar): Refactoring + a11y Apr 16, 2024
@Yakutoc Yakutoc marked this pull request as ready for review April 16, 2024 10:34
@Yakutoc Yakutoc requested review from TitanKuzmich and removed request for Yeti-or and TitanKuzmich April 16, 2024 10:34
@salute-developers salute-developers deleted a comment from github-actions bot Apr 16, 2024
@salute-developers salute-developers deleted a comment from github-actions bot Apr 16, 2024
Yeti-or
Yeti-or reviewed Apr 16, 2024
View reviewed changes
Copy link
Contributor

@Yeti-or Yeti-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

про мертвый код тоже в релиз ноутс пойдет ?

packages/plasma-new-hope/src/components/Avatar/Avatar.tsx Outdated Show resolved Hide resolved
@Yakutoc Yakutoc requested a review from neretin-trike April 18, 2024 09:58
@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@salute-developers salute-developers deleted a comment from github-actions bot Apr 18, 2024
@Yakutoc Yakutoc requested a review from shuga2704 April 19, 2024 04:39
@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@Yakutoc Yakutoc added this pull request to the merge queue Apr 19, 2024
Merged via the queue into dev with commit 06a6d79 Apr 19, 2024
28 checks passed
@Yakutoc Yakutoc deleted the fix-a11y-avatar branch April 19, 2024 09:22
@Yakutoc Yakutoc mentioned this pull request Apr 24, 2024
Merged
This was referenced Jul 24, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yeti-or Yeti-or Yeti-or approved these changes

@neretin-trike neretin-trike neretin-trike approved these changes

@shuga2704 shuga2704 shuga2704 approved these changes

Assignees

@Yakutoc Yakutoc

Labels
a11y plasma-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yakutoc @Yeti-or @neretin-trike @shuga2704