Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plasma-icons: Delete unnecessary prop opacity #1282

Merged
merged 4 commits into from
Jul 8, 2024
Merged

plasma-icons: Delete unnecessary prop opacity #1282

merged 4 commits into from
Jul 8, 2024

Conversation

Yakutoc
Copy link
Collaborator

@Yakutoc Yakutoc commented Jul 3, 2024 •
edited by Salute-Eva
Loading

Opacity

  • удалено ненужное свойство opacity

What/why changed

Свойство opacity для svg не нужно. Удалено. Преимущественно в старых иконках, в новых нет.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@Yakutoc Yakutoc self-assigned this Jul 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1282/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1282/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1282/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1282/b2c-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1282/ui-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1282/web-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1282/sdds-serv-storybook/
caldera-online storybook: https://plasma.sberdevices.ru/pr/pr-1282/caldera-online-storybook/

@Yakutoc Yakutoc force-pushed the fix-icons-delete-opacity branch from 66ef5b1 to bf76462 Compare July 4, 2024 03:47
@Yakutoc Yakutoc marked this pull request as ready for review July 4, 2024 04:14
@Yakutoc Yakutoc requested review from luizasok and removed request for Yeti-or July 4, 2024 04:14
Yeti-or
Yeti-or approved these changes Jul 5, 2024
View reviewed changes
.../b2c/components/Dropdown/Dropdown.component-test.tsx/plasma-b2c Dropdown -- default.snap.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

нужна задача на тех-долг: убрать использование deprecated иконок из примеров

@Yakutoc Yakutoc force-pushed the fix-icons-delete-opacity branch from bf76462 to 4a7a1b2 Compare July 5, 2024 11:34
@Yakutoc Yakutoc removed the request for review from shuga2704 July 5, 2024 11:36
@Yakutoc Yakutoc added this pull request to the merge queue Jul 8, 2024
Merged via the queue into dev with commit 340808f Jul 8, 2024
30 checks passed
@Yakutoc Yakutoc deleted the fix-icons-delete-opacity branch July 8, 2024 05:47
@Salute-Eva Salute-Eva mentioned this pull request Jul 11, 2024
Merged
This was referenced Jul 24, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luizasok luizasok luizasok approved these changes

@TitanKuzmich TitanKuzmich TitanKuzmich approved these changes

@neretin-trike neretin-trike neretin-trike approved these changes

@Yeti-or Yeti-or Yeti-or approved these changes

Assignees

@Yakutoc Yakutoc

Labels
plasma-icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Yakutoc @Yeti-or @neretin-trike @TitanKuzmich @luizasok