Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(textfield): refactor label placement #1287

Merged
merged 4 commits into from
Jul 8, 2024
Merged

feat(textfield): refactor label placement #1287

merged 4 commits into from
Jul 8, 2024

Conversation

TitanKuzmich
Copy link
Contributor

@TitanKuzmich TitanKuzmich commented Jul 5, 2024 •
edited by Salute-Eva
Loading

TextField

  • стили labelPlacement были вынесены из конфига

What/why changed

В конфиге должны быть только токены, без какой-либо логики и дополнительных стилей. Поэтому стили для labelPlacemnt были отрефакторены.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@TitanKuzmich TitanKuzmich added the changelog-skip Exclude pull request changes from changelog label Jul 5, 2024
@TitanKuzmich TitanKuzmich requested review from iljs and shuga2704 July 5, 2024 08:44
@TitanKuzmich TitanKuzmich self-assigned this Jul 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1287/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1287/
caldera-online storybook: https://plasma.sberdevices.ru/pr/pr-1287/caldera-online-storybook/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1287/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1287/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1287/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1287/web-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1287/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1287/ui-storybook/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich force-pushed the plasma-3128/refactor-textfield-label-placement branch from 7992cca to a193af4 Compare July 8, 2024 07:43
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich added this pull request to the merge queue Jul 8, 2024
Merged via the queue into dev with commit 03d48cc Jul 8, 2024
29 checks passed
@TitanKuzmich TitanKuzmich deleted the plasma-3128/refactor-textfield-label-placement branch July 8, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuga2704 shuga2704 shuga2704 approved these changes

@iljs iljs iljs approved these changes

Assignees

@TitanKuzmich TitanKuzmich

Labels
changelog-skip Exclude pull request changes from changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TitanKuzmich @iljs @shuga2704