Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plasma-*: Fix tech debt #1290

Merged
merged 2 commits into from
Jul 10, 2024
Merged

plasma-*: Fix tech debt #1290

merged 2 commits into from
Jul 10, 2024

Conversation

Yakutoc
Copy link
Collaborator

@Yakutoc Yakutoc commented Jul 9, 2024 •
edited
Loading

What/why changed

  • удален лишний console.log(computedBounds);
  • исправлен шаблон для Popup (был неправильный import)
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@Yakutoc Yakutoc added the changelog-skip Exclude pull request changes from changelog label Jul 9, 2024
@Yakutoc Yakutoc self-assigned this Jul 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1290/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1290/
caldera-online storybook: https://plasma.sberdevices.ru/pr/pr-1290/caldera-online-storybook/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1290/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1290/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1290/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1290/web-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1290/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1290/ui-storybook/

@Yakutoc Yakutoc marked this pull request as ready for review July 9, 2024 04:41
@Yakutoc Yakutoc removed request for Yeti-or and shuga2704 July 9, 2024 04:41
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

⚡ Component performance testing

Result: 🟢 OK

@Yakutoc Yakutoc force-pushed the fix-delete-console-log branch from 74e2621 to 7cc2256 Compare July 10, 2024 04:08
@Yakutoc Yakutoc changed the title plasma-new-hope: Delete unnecessary console.log plasma-*: Fix tech debt Jul 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@Yakutoc Yakutoc added this pull request to the merge queue Jul 10, 2024
Merged via the queue into dev with commit 584bf8a Jul 10, 2024
29 checks passed
@Yakutoc Yakutoc deleted the fix-delete-console-log branch July 10, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TitanKuzmich TitanKuzmich TitanKuzmich approved these changes

@neretin-trike neretin-trike neretin-trike approved these changes

Assignees

@Yakutoc Yakutoc

Labels
changelog-skip Exclude pull request changes from changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yakutoc @neretin-trike @TitanKuzmich