Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plasma-new-hope): Popup and Portal improvements #1299

Merged
merged 3 commits into from
Jul 16, 2024
Merged

fix(plasma-new-hope): Popup and Portal improvements #1299

merged 3 commits into from
Jul 16, 2024

Conversation

neretin-trike
Copy link
Collaborator

@neretin-trike neretin-trike commented Jul 12, 2024 •
edited by Yakutoc
Loading

Portal/Popup

  • убрана зависимость от свойства frame в элементе PopupRootContainer
  • переделан компонент Portal из конфигурируемого в обычный функциональный компонент

What/why changed

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@github-actions GitHub Actions
Copy link
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1299/

@github-actions GitHub Actions
Copy link
Contributor

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1299/
caldera-online storybook: https://plasma.sberdevices.ru/pr/pr-1299/caldera-online-storybook/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1299/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1299/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1299/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1299/web-storybook/
sdds-dfa storybook: https://plasma.sberdevices.ru/pr/pr-1299/sdds-dfa-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1299/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1299/ui-storybook/

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 💀 WASTED

Performance tests are broken.
If the current changes are the cause, please fix it immediately in this PR. If not, please schedule their repair.
For any questions, come to the Speed team.

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@neretin-trike neretin-trike changed the title fix(plasma-new-hope): Remove frame deps from PopupRootContainer element fix(plasma-new-hope): Popup and Portal improvements Jul 15, 2024
@neretin-trike neretin-trike requested review from denivladislav and removed request for Yeti-or, Yakutoc, TitanKuzmich and shuga2704 July 15, 2024 15:39
@neretin-trike neretin-trike requested a review from Yakutoc July 15, 2024 15:39
@neretin-trike neretin-trike added this pull request to the merge queue Jul 16, 2024
Merged via the queue into dev with commit 719734a Jul 16, 2024
30 checks passed
@neretin-trike neretin-trike deleted the neretinaa/fix-popup-style branch July 16, 2024 07:23
This was referenced Jul 24, 2024
Closed
Closed
Closed
Merged
@Yakutoc Yakutoc mentioned this pull request Oct 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denivladislav denivladislav denivladislav approved these changes

@Yakutoc Yakutoc Yakutoc approved these changes

Assignees

@neretin-trike neretin-trike

Labels
plasma-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neretin-trike @Yakutoc @denivladislav