Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add color prop in Typography #1308

Merged
merged 3 commits into from
Jul 24, 2024
Merged

feat: Add color prop in Typography #1308

merged 3 commits into from
Jul 24, 2024

Conversation

vadim-kudr
Copy link
Contributor

@vadim-kudr vadim-kudr commented Jul 17, 2024 •
edited by Salute-Eva
Loading

Typography

  • добавлен пропс color
  • в секции plasma-web storybook добавлен color picker

What/why changed

Пример использования:

<H3 color="lightblue"> hello Plasma </H3>
<H4 color={textAccent}> hello Plasma </H4>
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@github-actions GitHub Actions
Copy link
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1308/

@Yakutoc
Copy link
Collaborator

Yakutoc commented Jul 17, 2024

@vadim-kudr

Я думаю в раздел What/why changed можно добавить примеры нового использования этого свойства.

Что то типа - <H4 color={textAccent}> hello Plasma </H4>

@Yakutoc Yakutoc removed the request for review from Yeti-or July 17, 2024 09:35
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 17, 2024 •
edited
Loading

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1308/
caldera-online storybook: https://plasma.sberdevices.ru/pr/pr-1308/caldera-online-storybook/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1308/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1308/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1308/new-hope-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1308/ui-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1308/web-storybook/
sdds-dfa storybook: https://plasma.sberdevices.ru/pr/pr-1308/sdds-dfa-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1308/sdds-serv-storybook/

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@Yakutoc Yakutoc requested review from neretin-trike and removed request for neretin-trike July 19, 2024 06:52
@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@Yakutoc Yakutoc removed the request for review from shuga2704 July 23, 2024 08:36
@vadim-kudr vadim-kudr added this pull request to the merge queue Jul 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

Merged via the queue into dev with commit aca8f03 Jul 24, 2024
32 checks passed
@vadim-kudr vadim-kudr deleted the PLASMA-3133 branch July 24, 2024 09:08
Yeti-or
Yeti-or reviewed Jul 24, 2024
View reviewed changes
packages/caldera-online/api/caldera-online.api.md
@@ -99,6 +99,7 @@ l: PolymorphicClassName;
};
}> & {
breakWord?: boolean | undefined;
color?: string | undefined;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ребят а мы не можем / не хотим ограничить цвет только тем что есть в plasma-themes токенах ?

This was referenced Jul 24, 2024
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neretin-trike neretin-trike neretin-trike left review comments

@Yeti-or Yeti-or Yeti-or left review comments

@TitanKuzmich TitanKuzmich TitanKuzmich approved these changes

@Yakutoc Yakutoc Yakutoc approved these changes

Assignees

@vadim-kudr vadim-kudr

Labels
plasma-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vadim-kudr @Yakutoc @Yeti-or @neretin-trike @TitanKuzmich