Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plasma-*: add datepicker inner label support #1327

Merged
merged 6 commits into from
Jul 31, 2024
Merged

plasma-*: add datepicker inner label support #1327

merged 6 commits into from
Jul 31, 2024

Conversation

TitanKuzmich
Copy link
Contributor

@TitanKuzmich TitanKuzmich commented Jul 29, 2024 •
edited by Salute-Eva
Loading

DatePicker

  • добавлена возможность задавать labelPlacement
  • добавлен тест на данное свойство

What/why changed

DatePicker должен поддерживать те же свойства, что и TextField.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@TitanKuzmich TitanKuzmich self-assigned this Jul 29, 2024
@TitanKuzmich TitanKuzmich removed the request for review from Yeti-or July 29, 2024 14:42
@github-actions GitHub Actions
Copy link
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1327/

@github-actions GitHub Actions
Copy link
Contributor

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1327/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1327/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1327/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1327/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1327/web-storybook/
sdds-dfa storybook: https://plasma.sberdevices.ru/pr/pr-1327/sdds-dfa-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1327/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1327/ui-storybook/

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich force-pushed the plasma-3248/fix-datepicker-label branch from 8f71d50 to bcd7a3d Compare July 30, 2024 08:32
@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 💀 WASTED

Performance tests are broken.
If the current changes are the cause, please fix it immediately in this PR. If not, please schedule their repair.
For any questions, come to the Speed team.

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich force-pushed the plasma-3248/fix-datepicker-label branch from a619739 to 2312532 Compare July 30, 2024 15:03
@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich added this pull request to the merge queue Jul 31, 2024
Merged via the queue into dev with commit aad89fe Jul 31, 2024
29 checks passed
@TitanKuzmich TitanKuzmich deleted the plasma-3248/fix-datepicker-label branch July 31, 2024 07:54
@Salute-Eva Salute-Eva mentioned this pull request Aug 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denivladislav denivladislav denivladislav approved these changes

@iljs iljs iljs approved these changes

Assignees

@TitanKuzmich TitanKuzmich

Labels
plasma-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TitanKuzmich @iljs @denivladislav