Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLASMA-3197: update tokens and themes in plasma-{hope, b2c, web} #1646

Merged
merged 3 commits into from
Dec 28, 2024
Merged

PLASMA-3197: update tokens and themes in plasma-{hope, b2c, web} #1646

merged 3 commits into from
Dec 28, 2024

Conversation

denivladislav
Copy link
Contributor

@denivladislav denivladislav commented Dec 16, 2024 •
edited by Yakutoc
Loading

Core

Tokens

  • актуализированы токены для конфигураций компонентов

PLASMA-B2C

Tokens

  • актуализированы токены для конфигураций компонентов и тестов
  • обновлены snapshots для компонентов
  • добавлено подключение theme из plasma-themes для storybook в decoratorThemes

PLASMA-WEB

Tokens

  • актуализированы токены для конфигураций компонентов и тестов
  • обновлены snapshots для компонентов
  • добавлено подключение theme из plasma-themes для storybook в decoratorThemes

What/why changed

Актуализированы токены и темы в storybook; обновлены снэпшоты.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@github-actions GitHub Actions
Copy link
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1646/

@denivladislav denivladislav changed the title Plasma 3197 Plasma 3197: update tokens and themes in plasma-{b2c, web} Dec 16, 2024
@denivladislav denivladislav changed the title Plasma 3197: update tokens and themes in plasma-{b2c, web} [Do not merge] Plasma 3197: update tokens and themes in plasma-{b2c, web} Dec 16, 2024
@denivladislav denivladislav changed the title [Do not merge] Plasma 3197: update tokens and themes in plasma-{b2c, web} [Do not merge] PLASMA-3197: update tokens and themes in plasma-{b2c, web} Dec 16, 2024
@denivladislav denivladislav changed the title [Do not merge] PLASMA-3197: update tokens and themes in plasma-{b2c, web} [Do not merge until PR 1490] PLASMA-3197: update tokens and themes in plasma-{b2c, web} Dec 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024 •
edited
Loading

Documentation preview deployed!

website: https://plasma.sberdevices.ru/pr/pr-1646/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1646/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1646/b2c-storybook/
giga storybook: https://plasma.sberdevices.ru/pr/pr-1646/giga-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1646/new-hope-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1646/ui-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1646/web-storybook/
sdds-cs storybook: https://plasma.sberdevices.ru/pr/pr-1646/sdds-cs-storybook/
sdds-dfa storybook: https://plasma.sberdevices.ru/pr/pr-1646/sdds-dfa-storybook/
sdds-finportal storybook: https://plasma.sberdevices.ru/pr/pr-1646/sdds-finportal-storybook/
sdds-insol storybook: https://plasma.sberdevices.ru/pr/pr-1646/sdds-insol-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1646/sdds-serv-storybook/

@denivladislav denivladislav changed the title [Do not merge until PR 1490] PLASMA-3197: update tokens and themes in plasma-{b2c, web} PLASMA-3197: update tokens and themes in plasma-{b2c, web} Dec 19, 2024
@denivladislav denivladislav requested a review from Irinkv December 19, 2024 11:48
@denivladislav denivladislav marked this pull request as ready for review December 24, 2024 06:28
@github-actions github-actions bot requested review from iljs and vadim-kudr and removed request for shuga2704 December 24, 2024 06:29
@neretin-trike
Copy link
Collaborator

neretin-trike commented Dec 25, 2024 •
edited
Loading

в целом вроде всё оке, но есть пара вопросов:

  • почему не стал в plasma-hope эти замены делать? Просто там остались ещё некоторые компоненты, которые используются в b2c / web, и если пользователи будут подключать темы по "новому способу", то некоторые компоненты могут оказаться без токенов
  • все ли токены, которые используются в конфигах, есть в "старых темах", т.е. plasma-tokens и plasma-tokens-b2c/web/b2b ?

@denivladislav denivladislav changed the title PLASMA-3197: update tokens and themes in plasma-{b2c, web} PLASMA-3197: update tokens and themes in plasma-{hope, b2c, web} Dec 28, 2024
@denivladislav denivladislav added this pull request to the merge queue Dec 28, 2024
Merged via the queue into dev with commit 83dcd29 Dec 28, 2024
35 checks passed
@denivladislav denivladislav deleted the PLASMA-3197 branch December 28, 2024 07:40
@Salute-Eva Salute-Eva mentioned this pull request Jan 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Irinkv Irinkv Irinkv approved these changes

@iljs iljs iljs approved these changes

@neretin-trike neretin-trike neretin-trike approved these changes

@vadim-kudr vadim-kudr vadim-kudr approved these changes

Assignees

@denivladislav denivladislav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@denivladislav @neretin-trike @vadim-kudr @iljs @Irinkv