Update Rust crate thiserror to v1.0.62 #97
renovate[bot]Annotations
22 warnings
|
`to_string` applied to a type that implements `Display` in `println!` args:
src/main.rs#L36
warning: `to_string` applied to a type that implements `Display` in `println!` args
--> src/main.rs:36:36
|
36 | println!("Error: {}", e.to_string());
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
= note: `#[warn(clippy::to_string_in_format_args)]` on by default
|
|
`to_string` applied to a type that implements `Display` in `println!` args:
src/main.rs#L36
warning: `to_string` applied to a type that implements `Display` in `println!` args
--> src/main.rs:36:36
|
36 | println!("Error: {}", e.to_string());
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
= note: `#[warn(clippy::to_string_in_format_args)]` on by default
|
|
methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value:
src/tile.rs#L68
warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value
--> src/tile.rs:68:34
|
68 | pub(crate) fn to_test_string(&self) -> String {
| ^^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
= note: `#[warn(clippy::wrong_self_convention)]` on by default
|
|
methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value:
src/tile.rs#L68
warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value
--> src/tile.rs:68:34
|
68 | pub(crate) fn to_test_string(&self) -> String {
| ^^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
= note: `#[warn(clippy::wrong_self_convention)]` on by default
|
|
casting to the same type is unnecessary (`char` -> `char`):
src/importer/sdk.rs#L36
warning: casting to the same type is unnecessary (`char` -> `char`)
--> src/importer/sdk.rs:36:27
|
36 | match *tile as char {
| ^^^^^^^^^^^^^ help: try: `{ *tile }`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
|
the loop variable `i` is used to index `tiles`:
src/helpers.rs#L51
warning: the loop variable `i` is used to index `tiles`
--> src/helpers.rs:51:14
|
51 | for i in 0..9 {
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
help: consider using an iterator and enumerate()
|
51 | for (i, <item>) in tiles.iter_mut().enumerate() {
| ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
casting to the same type is unnecessary (`char` -> `char`):
src/importer/sdk.rs#L36
warning: casting to the same type is unnecessary (`char` -> `char`)
--> src/importer/sdk.rs:36:27
|
36 | match *tile as char {
| ^^^^^^^^^^^^^ help: try: `{ *tile }`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
|
the loop variable `i` is used to index `tiles`:
src/helpers.rs#L51
warning: the loop variable `i` is used to index `tiles`
--> src/helpers.rs:51:14
|
51 | for i in 0..9 {
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
help: consider using an iterator and enumerate()
|
51 | for (i, <item>) in tiles.iter_mut().enumerate() {
| ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
the borrowed expression implements the required traits:
src/helpers.rs#L13
warning: the borrowed expression implements the required traits
--> src/helpers.rs:13:16
|
13 | File::open(&path).map_err(|_| SudokuError::FileRead(filename.to_string()))
| ^^^^^ help: change this to: `path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
|
the borrowed expression implements the required traits:
src/helpers.rs#L13
warning: the borrowed expression implements the required traits
--> src/helpers.rs:13:16
|
13 | File::open(&path).map_err(|_| SudokuError::FileRead(filename.to_string()))
| ^^^^^ help: change this to: `path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
|
it looks like you're manually copying between slices:
src/board.rs#L88
warning: it looks like you're manually copying between slices
--> src/board.rs:88:17
|
88 | / for y in 0..9 {
89 | | tiles[y] = self.grid[row as usize][y];
90 | | }
| |_________________^ help: try replacing the loop by: `tiles.copy_from_slice(&self.grid[row as usize]);`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
= note: `#[warn(clippy::manual_memcpy)]` on by default
|
|
it looks like you're manually copying between slices:
src/board.rs#L88
warning: it looks like you're manually copying between slices
--> src/board.rs:88:17
|
88 | / for y in 0..9 {
89 | | tiles[y] = self.grid[row as usize][y];
90 | | }
| |_________________^ help: try replacing the loop by: `tiles.copy_from_slice(&self.grid[row as usize]);`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
= note: `#[warn(clippy::manual_memcpy)]` on by default
|
|
the loop variable `x` is used to index `tiles`:
src/board.rs#L83
warning: the loop variable `x` is used to index `tiles`
--> src/board.rs:83:26
|
83 | for x in 0..9 {
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
= note: `#[warn(clippy::needless_range_loop)]` on by default
help: consider using an iterator and enumerate()
|
83 | for (x, <item>) in tiles.iter_mut().enumerate() {
| ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
the loop variable `x` is used to index `tiles`:
src/board.rs#L83
warning: the loop variable `x` is used to index `tiles`
--> src/board.rs:83:26
|
83 | for x in 0..9 {
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
= note: `#[warn(clippy::needless_range_loop)]` on by default
help: consider using an iterator and enumerate()
|
83 | for (x, <item>) in tiles.iter_mut().enumerate() {
| ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
lint
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
test
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|