Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for archive pages #28

Closed
wants to merge 3 commits into from
Closed

Add support for archive pages #28

wants to merge 3 commits into from

Conversation

benniemosher
Copy link
Contributor

@benniemosher benniemosher commented Jan 8, 2020

Solves #8 and #24

Can be demoed at https://benniemosher.com

@samarsault
Copy link
Owner

Woudn't it be better if instead of the user creating the category.html file, it is included by default ?

@benniemosher
Copy link
Contributor Author

@thelehhman I tried putting it in the theme, but then when you try and go to /categories/#Learning it returns a 404. I put the categories.html in my personal site repo and it renders just fine. I can't figure out why that is or how to fix it. Thoughts?

@samarsault
Copy link
Owner

Okay it looks great!

Before merging however, please account for the following

  1. Update your base branch to include the latest version fix jekyll v3.8.6 #24
  2. Don't increment version number. Keep it at 0.9. It's yet to be released
  3. Rebase all the commits into 2-3 commits max.

Thank you :)

@benniemosher
Copy link
Contributor Author

Created a new PR with an updated base project. This should allow me to rebase off of upstream easier later. #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants