Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ElementsMatch, ElementsMatchBy #589

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

senago
Copy link
Contributor

@senago senago commented Feb 7, 2025

Solves #586

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.31%. Comparing base (70b763e) to head (2a222db).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #589      +/-   ##
==========================================
+ Coverage   94.27%   94.31%   +0.03%     
==========================================
  Files          18       18              
  Lines        3178     3200      +22     
==========================================
+ Hits         2996     3018      +22     
  Misses        170      170              
  Partials       12       12              
Flag Coverage Δ
unittests 94.31% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@senago
Copy link
Contributor Author

senago commented Feb 7, 2025

I'm actually not sure If we should count the elements. So is done in testify package: ElementsMatch. That's the intent - to have the same familiar semantics. Though personally I don't find this counting really helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant