Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include from nimble files is fragile #98

Closed
Nycto opened this issue Feb 5, 2025 · 1 comment
Closed

Include from nimble files is fragile #98

Nycto opened this issue Feb 5, 2025 · 1 comment

Comments

@Nycto
Copy link
Collaborator

Nycto commented Feb 5, 2025

The way that playdate-nim currently integrates with Nimble by adding an include to the consumers nimble files is very fragile. It causes a few problems:

  • Reports of the language server being broken (LSP error with VSCode and config.nims file #89)
  • Requires running nimble install playdate before running a build. This is a break from the regular nimble process
  • When it fails, it causes confusing error messages
  • Makes development on this library hard, as running nimble install playdate installs the latest version, not the in development version. This means the build scripts are on the previous version
  • Apparently, it doesn't work with nimble lock, though I didn't test this too hard

We need to find another way of dealing with this.

One possible mechanism would be to vend a bin that wraps nimble. So instead of calling nimble simulate, folks would call pdbuild simulate. We could then strive to make all existing nimble commands work as expected, so folks would only interact with pdbuild when performing playdate specific actions.

Other ideas and possible solutions are welcome

Nycto added a commit to Nycto/playdate-nim that referenced this issue Feb 13, 2025
Nycto added a commit to Nycto/playdate-nim that referenced this issue Feb 13, 2025
Nycto added a commit to Nycto/playdate-nim that referenced this issue Feb 13, 2025
Nycto added a commit to Nycto/playdate-nim that referenced this issue Feb 13, 2025
Nycto added a commit to Nycto/playdate-nim that referenced this issue Feb 13, 2025
Nycto added a commit to Nycto/playdate-nim that referenced this issue Feb 13, 2025
Nycto added a commit to Nycto/playdate-nim that referenced this issue Feb 13, 2025
Nycto added a commit to Nycto/playdate-nim that referenced this issue Feb 13, 2025
Nycto added a commit to Nycto/playdate-nim that referenced this issue Feb 13, 2025
Nycto added a commit that referenced this issue Feb 14, 2025
@Nycto
Copy link
Collaborator Author

Nycto commented Feb 14, 2025

Resolving, as the pdn build command landed in the dev branch

@Nycto Nycto closed this as completed Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant