Support launchSoundPath and contentWarning in pdxinfo #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninovanhooff
approved these changes
Feb 23, 2025
There was a problem hiding this comment.
LGTM
I considered for a second whether a Map aka Table would be preferable for flexibility and future proofing. That is also more in line with the Lua Api https://sdk.play.date/2.6.2/Inside%20Playdate.html#f-metadata.
I think this table approach is related to what is canonical in Lua and doesn't necessarily translate to Nim.
And I hate dealing with key not found errors so let's do it in a declared way like this 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for missing
pdxinfoproperties