Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unfindable entry in sparsemap #93

Merged
merged 4 commits into from
Jan 23, 2025
Merged

Fix unfindable entry in sparsemap #93

merged 4 commits into from
Jan 23, 2025

Conversation

Nycto
Copy link
Collaborator

@Nycto Nycto commented Dec 28, 2024

A few changes contained here:

  1. Fixes a bug in the bundled sparsemap implementation that was preventing some entries from being located.
  2. Adds a bulk operations test that runs the map through a long list of operations
  3. Moves sparsemap.nim into a util directory
  4. Adds github actions for specifically testing with the various memory profiling modes enabled.

@Nycto Nycto requested a review from ninovanhooff December 28, 2024 02:41
@Nycto Nycto changed the title Fix bug in sparsemap implementation Fix unfindable entry in sparsemap Dec 28, 2024
@Nycto
Copy link
Collaborator Author

Nycto commented Jan 12, 2025

@ninovanhooff Any other concerns here?

@ninovanhooff
Copy link
Collaborator

@Nycto nope, go ahead

@Nycto Nycto merged commit cdca53b into samdze:dev Jan 23, 2025
7 checks passed
@Nycto Nycto deleted the sparsemap branch January 23, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants