-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Wowza 4.3.0 #10
Conversation
Should I resolve conflicts and add a developer key or do you think this is a bad approach? |
@mtneug I have no issues with the approach, Earlier I was also considering using expect to perform the installation. But since the installer required a key for the install to happen I did not do it. My concern really is with the publicly visible key. I am not sure how wowza media would feel about this and/or whether the wowza EULA allows users to expose their license key like the one you linked to in your previous comment. It sure is an expired key, but still. I have been contacted by their lawyer on a previous occasion, but this might be crossing the line. What are your thought on this? One possible workaround is installing wowza at runtime with a user specified license key. This will obviously effect the startup time of the container but at least it will make the image usable with the new wowza versions. |
While I'm not sure if it is against the EULA (at least some sections read like that), it's probably best to be on the safe side. Installing Wowza at runtime seems fine to me. I don't mind the longer startup time. I will try to implement it this week. For that would you prefer to download the Wowza installer during image build or at runtime, i.e. size vs. startup time? |
Thanks for your efforts.
Pre-downloaded installer at build time should be fine I think. There is one other possible option. If we can configure a CI server to install wowza using expect and then tar all the installed components and make the tarball available as a build artifact, then we could use that tarball as the install package with this image. I think should be able to protect the license key used while installing the package using private CI variables. I have not tried this sort of thing before, but should definitely be possible. In the wowza forums I remember this being suggested by one of the support people for an unattended install. |
scratch that, lets stay out of trouble. |
OK, installation is now done during container start. I moved the license check before the installation, as it is there where this question is asked originally. |
@mtneug will review/test and merge |
@mtneug have merged the PR. However I reverted the version number changes in the README and other places to Holding back on a new tag to allow some more time to test the changes and/or make improvements. |
Thanks for the merge 😃 |
Looking for solutions for issue #6, I came across ansible-wowza which uses expect to interact with the installer. After some changes to the expect script I ended up with
interaction.exp
.On problem still remains thou. The installer expects a "real" license key, i.e.
send -- "xxxxx-xxxxx-xxxxx-xxxxx-xxxxx-xxxxx-xxxxxxxxxxxx\r"
in line 15 will not work. However you probably should be able to use an old developer key. I was able to continue the installation with this key. Note thatServer.license
is removed so that no Wowza Engine is started with that key.