ERD #2
Merged
ERD #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriaanbd
suggested changes
Sep 15, 2019
There was a problem hiding this comment.
Thanks for sharing a drawing of your ERD. Pen and paper is okay but I'd really recommend using a free online tool like LucidChart, ERDPlus or any other one. There are so many out there that it's hard to keep track of them. They are good to use because it makes this look professional. That being said, there is something missing in your ERD.
The User table needs an image_link column to store the avatar, unless you have a different approach in mind. The Invitee and Invitation_sender have the correct association but the choice of name throws me off a bit. If that's how you choose to name them it's okay.
Let's include the image_link column and proceed with another code review request.
Status: Request changes
…s in the friendship model
This was referenced Sep 26, 2019
Merged
This was referenced Oct 3, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I have created the ERD for the project.
Located in: docs/ok.jpeg