Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone2 project setup - Second review #4

Merged
merged 6 commits into from
Sep 19, 2019

Conversation

samgaco
Copy link
Owner

@samgaco samgaco commented Sep 18, 2019

Corrected changes

I got the first review for this milestone here #3

First review:

  • added the gems for Omniauth and devise, and added the configuration to use Rspec.

Second review:

  • Pull request is to the development branch this time.
  • I added the stickler files and corrected the offenses.
  • I am working solo for this project under the consent of the student success team.

@samgaco samgaco changed the title Milestone2 project setup Milestone2 project setup - Second review Sep 18, 2019
Copy link

@bellom bellom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @samgaco,

Wonderful Job changing to git flow 👍

For some reason you didn't get to successfully install linter's check on this PR github page, you should have the check just as we have in the screenshot below...
image
I trust you could do this, kindly move on to the next milestone after adding the linter's check and don't forget to merge to dev branch
kindly go through this link to get it working.

Congratulation 👍

Goodluck in the next milestone

@samgaco
Copy link
Owner Author

samgaco commented Sep 19, 2019

Hi @bellom

I went through that link until I got to this point:

  1. Stickler does not work and nothing helps 💥 - run rubocop in your local env:
    • add gem 'rubocop' to Gemfile (not sure how to use Gemfile? Read this)
    • run bundle install
    • copy .rubocop.yml to the root directory of your project
    • run rubocop
    • fix linter errors
    • Remember to let your Code Reviewer know that you had problems with Stickler and you used linter in local env.

Anyways, I will keep trying to correct it so the linter checks appear moving on. I will merge the branch by now because I don't seem to find it yet, and the offenses I solved them locally.

@samgaco samgaco merged commit f20a819 into development Sep 19, 2019
This was referenced Sep 23, 2019
@samgaco samgaco mentioned this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants