Update index.html #3
Conversation
Here are the optimizations I made to the HTML code: Removed unnecessary comments: I removed the comment indicating the font awesome link since it is self-explanatory in the code. Added meta tags: I added <meta> tags for character encoding and viewport to improve the HTML document's compatibility and responsiveness. Added a Google Fonts link: I included a link to the Google Fonts API to import the "Roboto" font, which is used for the body text. Minimized CSS styling: I extracted the CSS styles into the <style> tags within the HTML file to avoid the need for an external CSS file. Additionally, I optimized and simplified the CSS styles by grouping common properties and removing redundant styles. Removed unused classes: The original code had unnecessary classes on the <header> and <article> elements, which I removed since they were not being used. By implementing these optimizations, the HTML code becomes more streamlined and efficient.
|
Here are the optimizations I made to the HTML code: Removed unnecessary comments: I removed the comment indicating the font awesome link since it is self-explanatory in the code. Added meta tags: I added tags for character encoding and viewport to improve the HTML document's compatibility and responsiveness. Added a Google Fonts link: I included a link to the Google Fonts API to import the "Roboto" font, which is used for the body text. Minimized CSS styling: I extracted the CSS styles into the <style> tags within the HTML file to avoid the need for an external CSS file. Additionally, I optimized and simplified the CSS styles by grouping common properties and removing redundant styles. Removed unused classes: The original code had unnecessary classes on the and elements, which I removed since they were not being used.By implementing these optimizations, the HTML code becomes more streamlined and efficient. |
|
@GunaPalanivel thank you for creating PR. Don't add internal CSS and external CSS file looks for optimized. Remaining changes are good to go. Kindly fix it. |
| <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/5.15.4/css/all.min.css"> | ||
| <!-- your css styling file --> | ||
| <link rel="stylesheet" href="style.css"> | ||
| <style> |
| list-style: disc; | ||
| padding-left: 20px; | ||
| } | ||
| </style> |
|
Okay I'll update the code in three to four days,
I'm having my semester right now that's why.
…On Thu, 25 May 2023, 9:15 pm MUHAMMAD SAMIULLAH, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In index.html
<#3 (comment)>
:
> <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/5.15.4/css/all.min.css">
- <!-- your css styling file -->
- <link rel="stylesheet" href="style.css">
+ <style>
No need of this correction.
------------------------------
In index.html
<#3 (comment)>
:
> + flex-basis: 48%;
+ }
+
+ section {
+ margin-bottom: 20px;
+ }
+
+ i {
+ margin-right: 5px;
+ }
+
+ ul {
+ list-style: disc;
+ padding-left: 20px;
+ }
+ </style>
Kindly remove internal CSS
—
Reply to this email directly, view it on GitHub
<#3 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2VFWVLRNHXTLGPXYVUJV7TXH55ATANCNFSM6AAAAAAYMDCD7A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sure, take your time. |
|
Sounds good, thanks!
On Thu, May 25, 2023 at 10:51 PM MUHAMMAD SAMIULLAH <
***@***.***> wrote:
… Okay I'll update the code in three to four days, I'm having my semester
right now that's why.
… <#m_-515119110627379144_>
On Thu, 25 May 2023, 9:15 pm MUHAMMAD SAMIULLAH, *@*.*> wrote: @.**
requested changes on this pull request. ------------------------------ In
index.html <#3 (comment)
<#3 (comment)>>
: > - - + <style> No need of this correction.
------------------------------ In index.html <#3 (comment)
<#3 (comment)>>
: > + flex-basis: 48%; + } + + section { + margin-bottom: 20px; + } + + i {
+ margin-right: 5px; + } + + ul { + list-style: disc; + padding-left: 20px;
+ } + </style> Kindly remove internal CSS — Reply to this email directly,
view it on GitHub <#3 (review)
<#3 (review)>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A2VFWVLRNHXTLGPXYVUJV7TXH55ATANCNFSM6AAAAAAYMDCD7A
. You are receiving this because you were mentioned.Message ID: *@*.***>
Sure, take your time.
—
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2VFWVPROHVZE7XULNXWQ53XH6IIRANCNFSM6AAAAAAYMDCD7A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Here are the optimizations I made to the HTML code:
Removed unnecessary comments: I removed the comment indicating the font awesome link since it is self-explanatory in the code.
Added meta tags: I added tags for character encoding and viewport to improve the HTML document's compatibility and responsiveness.
Added a Google Fonts link: I included a link to the Google Fonts API to import the "Roboto" font, which is used for the body text.
Minimized CSS styling: I extracted the CSS styles into the <style> tags within the HTML file to avoid the need for an external CSS file. Additionally, I optimized and simplified the CSS styles by grouping common properties and removing redundant styles.
Removed unused classes: The original code had unnecessary classes on the
and elements, which I removed since they were not being used.By implementing these optimizations, the HTML code becomes more streamlined and efficient.