Refactor to typescript #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Superjo149 this PR seems great. I would assume at this point that it probably won't be merged. Do you have any plans on publishing the fork you've created, or are you not really using this library anymore? |
|
@ttay24 I abandoned this project a while back, and it'd require further updates to function now in Electron 14 and up due to the removal of If something about how this library is set up makes you want a working typed version of this this over that, I might be willing to update this one since there'd be some value there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have converted the project to typescript, to increase the maintainability with breaking changes in electron. And also to provide types for typescript projects.
During this refactor, I have also taken the liberty to write test cases for some of the possible options. Which led me to see that #68 is not possible. The functionality has been removed in this PR. Unless you have an other suggestion, I would remove it, since it does not work. Implementing something that doesn't send functions through IPC will be more work for sure.
I have also updated to README since I thought that needed some love to.
What do you think?