Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate user options and deps inclusion #104

Merged

Conversation

benpbolton
Copy link
Contributor

moving the per-script inclusion to a single location (minor don't-repeat-yourself qualm)

✔️ I've confirmed functionality in a (small) production environment
✔️ Should require no migration/documentation updates

moving the per-script inclusion to a single location
@benpbolton
Copy link
Contributor Author

Thanks for maintaining this project - absolutely fine to close this up if it introduces undesired complexity.

Copy link
Owner

@samrocketman samrocketman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense to me. Thanks for the contribution.

@samrocketman samrocketman merged commit 73bd66e into samrocketman:development May 25, 2018
@benpbolton benpbolton deleted the feature/consolidate-deps branch May 29, 2018 14:02
lonet4 pushed a commit to lonet4/gitlab-mirrors that referenced this pull request Nov 13, 2018
* consolidate user options and deps inclusion

moving the per-script inclusion to a single location

* add trailing newline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants