Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some const strings, fixed some typos and add default value for GetExtension method #95

Merged
merged 2 commits into from
May 11, 2020

Conversation

StefH
Copy link
Contributor

@StefH StefH commented May 2, 2020

  • Fixed some typos
  • Add some const strings
  • Used nameof in throwing exceptions
  • Added a default value for method GetExtension

- Fixed some typos
- Lower TargetFramework to net40 and netstandard1.1
- Added TargetFramework dependency netstandard2.x
- Remove TargetFramework netcoreapp2.0 (not needed because netstandard2.x is enough)
- Add some const strings
- Used nameof in throwing exceptions
- Added a default value for method GetExtension
@samuelneff
Copy link
Owner

@StefH Thanks for the great additions and corrections. Everything in the map file is perfect.

I can't accept the project file changes though. Some people are dependent on that specific targeting. If you can undo just that change for the PR I'll be grateful to merge the rest of the changes.

@StefH
Copy link
Contributor Author

StefH commented May 11, 2020

Hello @samuelneff,
I can revert the TargetFrameworks change, however I would like to explain why I did this: all I did was lower the dependencies, which is good because more projects / people can use it.

  • net45 --> I lowered this to net40
  • netcoreapp2.0 --> I removed this because netstandard2.0 is enough, there is no need to support netcoreapp2.x or 3.x
  • netstandard2.0 --> I kept this one, and also lowered to 1.1 and included 2.1

I you still would like to keep the TargetFrameworks as-is, no problem, I'll revert this in the PR.

@samuelneff
Copy link
Owner

Thanks for explaining. I haven't programmed in .NET myself in years so I don't know enough to discuss the impact of the project change. I'd prefer if you left the project as is simply to maintain status-quo.

I appreciate your understanding.

Sam

@StefH StefH changed the title Updated TargetFrameworks, added some const strings, fixed some typos and add default value for GetExtension method Added some const strings, fixed some typos and add default value for GetExtension method May 11, 2020
@StefH
Copy link
Contributor Author

StefH commented May 11, 2020

OK. I've reverted the changes on TargetFrameworks. Maybe I'll create a new issue on this and let other users comment on this.

When do you plan to release a new NuGet ?

@samuelneff samuelneff merged commit 741c3ca into samuelneff:master May 11, 2020
@samuelneff
Copy link
Owner

@StefH Thanks for the updates. I don't control the NuGet packages. A few other people have published them but it's not something I've been involved with.

@StefH StefH deleted the stef_refactor_nullable branch July 19, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants