Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display thumbnail in search results. #316

Merged
merged 2 commits into from
Nov 20, 2013

Conversation

rbalekai
Copy link
Contributor

Fixes ndlib/planning#339

Fixes ndlib/planning#339

Refactor representative object

Refactoring thumbnail not to fetch from fedora each time

Remove representative_object method as its not needed

Removing duplicate view

Refactor Generic File to be represented

Make the first file as representative file
@cbeer
Copy link

cbeer commented Nov 19, 2013

What's the delta between this and the native thumbnail support in Blacklight? Is there anything here that should get pushed upstream?

@jeremyf
Copy link
Contributor

jeremyf commented Nov 19, 2013

@cbeer we're not familiar with the native thumbnail support of Blacklight, so I don't think we can answer. However, I'll explain what is going on to see how that jives with your understanding:

Most objects (Works and Collections) in our catalog controller response do not have files directly attached to them. Instead they have multiple GenericFile objects associated with them. Each GenericFile has a file and derivatives (e.g. thumbnail). A catalog object has a representative – a to_param for one of its GenericFiles. That representative is then used for the thumbnail.

@jeremyf
Copy link
Contributor

jeremyf commented Nov 19, 2013

@cbeer - We are storing the NOID of another file, so what would we need to do for the thumbnail? We also are making use of customized partials for each SOLR document, which likely won't be a problem, but we'd need to see how they play with Blacklight's output.

jeremyf added a commit that referenced this pull request Nov 20, 2013
…arch-results

Display thumbnail in search results.
@jeremyf jeremyf merged commit 0ffe832 into master Nov 20, 2013
@jeremyf jeremyf deleted the 339-display-thumbnail-in-search-results branch November 20, 2013 14:16
scherztc added a commit to uclibs/curate_archive that referenced this pull request May 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants