Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Prev/next canvas buttons break #258

Closed
elynema opened this issue Oct 5, 2023 · 5 comments
Closed

[BUG] Prev/next canvas buttons break #258

elynema opened this issue Oct 5, 2023 · 5 comments
Assignees
Labels
bug 🐛 Something isn't working

Comments

@elynema
Copy link

elynema commented Oct 5, 2023

Description

For some records the prev and / or next canvas buttons in the Ramp media player cause the screen to go blank and generate null pointer errors in the developer's console. Dananji thinks it's a bug with markers used in VideoJS to highlight the structure in the progress bar.

Note that this does not necessarily happen when navigating between every canvas on the media object.

Here is an example of what happens after clicking on prev and / or next.

Private Zenhub Image

To Reproduce

Here are some example records that have this issue as you use the prev / next canvas buttons:

Environment

Mac OS laptop, Chrome, avalon-dev

Release

Avalon 7.7

@elynema elynema added the bug 🐛 Something isn't working label Oct 5, 2023
@elynema
Copy link
Author

elynema commented Oct 6, 2023

Could be a simple check to see whether there is structure or it could be some type of merge conflict.

@elynema
Copy link
Author

elynema commented Oct 20, 2023

Ready to QA on avalon-dev.

@charumitraravi
Copy link
Collaborator

charumitraravi commented Oct 24, 2023

I performed QA on the 3 items mentioned in the bug, and there were no issues.
Although, I could still find the null pointer issue happening for the 4th section in this item - https://avalon-dev.dlib.indiana.edu/media_objects/g158bh28p - and the page becomes blank
@Dananji @elynema

@elynema
Copy link
Author

elynema commented Oct 24, 2023

@charumitraravi @Dananji I believe that is a known issue -- the third section on that item is missing derivatives; there is a placeholderCanvas message in the IIIF manifest, but Ramp is not displaying that yet.

Charu, are you sure it's the 4th section? I had the issue with the 3rd section.

@charumitraravi
Copy link
Collaborator

@elynema It is the 3rd section. Thanks for noting it.

@elynema elynema closed this as completed Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants