Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ramp should fail gracefully when it encounters an error #5416

Open
cjcolvar opened this issue Oct 10, 2023 · 1 comment
Open

Ramp should fail gracefully when it encounters an error #5416

cjcolvar opened this issue Oct 10, 2023 · 1 comment

Comments

@cjcolvar
Copy link
Member

We've encountered a number of bugs in ramp or avalon that result in an unusable and confusing interface.
See samvera-labs/ramp#258, #5385, #5350

Current behavior

When ramp encounters an issue, all of ramp disappears and the content section of the page is just white.

Expected behavior

When ramp encounters an issue, a message is shown to the user and parts of ramp unrelated to the error are still usable (e.g. if a section fails to load then other sections are still playable).

@joncameron
Copy link
Contributor

React ErrorBoundaries could be used in Ramp to capture errors bubbling up from children components and could be given a message to display. We could do this on the Ramp side, to avoid the issue of nothing rendering, whatever the error within Ramp is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants