-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Expand/Close button in StructuredNav Component #645
Comments
Screen.Recording.2024-11-08.at.11.13.41.AM.mov |
In my testing, across all platforms I have observed that the button text does not update if all sections are manually opened or closed:
This happens even if there is only 1 section. Also across all platforms, if the user loads page and clicks "Close [x] sections" button, then starts playback, the first section does not pop open when playback starts (the second one does). |
Note that aside from these minor issues, the new button is working wonderfully!! I asked Dananji to take a look at the last issue reported here (the first section does not open when playback begins if all sections are closed prior to playback). @joncameron Do you think we should create new issues for either of the other minor issues above? |
Description
With the on-going state management refactor using custom hooks (#630), we are able to implement expand/close functionality for each section in the structured navigation in Ramp.
We were not able to do this before due re-rendering in StructuredNavigation component, therefore this functionality was implemented in Avalon code.
Done Looks Like
Related work
#644
This work is based off of state management refactor. So if this work is re-purposed when working on this issue it needs to be rebased off
main
branch.The text was updated successfully, but these errors were encountered: