Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collapse/expand all button behavior with each section status change #729

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

Dananji
Copy link
Collaborator

@Dananji Dananji commented Nov 8, 2024

Related issues: #645 , #731, #732

Update collapse/expand all button when each section is changed manually:

Screen.Recording.2024-11-11.at.1.41.51.PM.mov

Expand current section when playback status changes for it:

Screen.Recording.2024-11-11.at.1.50.39.PM.mov

@Dananji Dananji marked this pull request as ready for review November 11, 2024 18:51
@Dananji Dananji changed the title [WIP] Fix collapse/expand all button behavior with each section status change Fix collapse/expand all button behavior with each section status change Nov 11, 2024
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused by the code but I did some manual testing and it all looked good as far as I could tell.

@Dananji Dananji merged commit 769cdb8 into main Nov 12, 2024
2 checks passed
@Dananji Dananji deleted the collapse-all-fix branch November 12, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants