-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore background to bring together progress bar and video.js widgets #659
Comments
I found a VideoJS plugin which brings together icons in the progress bar: https://github.com/samueleastdev/videojs-setting-menu
So, I brought in the code to Ramp as a custom plugin to see whether we can change things around to include what we want in the menu and I got the following; Settings menu; Work to do:
Related work: |
After standup and being clarified on the issue; I looked at the following players to see how the popup menus look like;
For reference Ramp's player has |
@joncameron and @elynema I forgot ask about this in Backlog buddies. Is there any preferred changes to the popup menus we can do based on these findings? Or do we need further investigation? |
We are looking at shading behind the widget bar and progress bar, not behind the popup menus: LinkedIn Learning (above) does have a shading you can see, although opacity decreases as the shading moves up to the progress bar. Looking at Youtube, there is a very subtle shading at the bottom that seems to fade away before the progress bar. I didn't see any shading on Netflix. Given what I was seeing with Youtube, we might want to come back to this after we add some padding around the progress bar and see if we feel like it is still needed. |
With padding changes from #687, I think things look ok and we don't need any changes to background color / opacity. |
Description
In the new multi-line display of progress bar and video.js widgets in Ramp, there's not background color that brings those 2 elements together into a group. Some type of gray background could be useful here.
Current Ramp in Avalon:
![image](https://private-user-images.githubusercontent.com/109625239/374706978-d0bfda40-c154-4637-99e0-168a024073fd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1MzQ5MTgsIm5iZiI6MTczOTUzNDYxOCwicGF0aCI6Ii8xMDk2MjUyMzkvMzc0NzA2OTc4LWQwYmZkYTQwLWMxNTQtNDYzNy05OWUwLTE2OGEwMjQwNzNmZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQxMjAzMzhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03YjU4MzQ0NjRlNDRiNzU5MjhjZGM0NGFlZjBhOTZkOTM4M2E4Zjk0ZjgwMWIzM2JjZTU2NmI3MTU1NWE0Y2I1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.NoPqoqcwacTqMqNq3IhDNIXrVznzySBO2Dgfa7i_SRQ)
Current MCO:
![image](https://private-user-images.githubusercontent.com/109625239/374706803-c431b360-da4b-4b58-8052-fc713c53ec80.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1MzQ5MTgsIm5iZiI6MTczOTUzNDYxOCwicGF0aCI6Ii8xMDk2MjUyMzkvMzc0NzA2ODAzLWM0MzFiMzYwLWRhNGItNGI1OC04MDUyLWZjNzEzYzUzZWM4MC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQxMjAzMzhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0zYTZlMzgwOTA1NzgwMWVlMWY5NmNlZWUzYzc1Mjc4NjczMGJkNTBmY2NmMGM4YmM4ODA3Y2I1ZGVjNDZiNzI5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.6uZQkXwJfGKHgf7cjY1-4Rmx4C1EPDjg9pFVcZTo5z0)
LinkedIn example:
![image](https://private-user-images.githubusercontent.com/109625239/374706707-5e421411-620b-454f-b503-5cba9c4f5f04.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1MzQ5MTgsIm5iZiI6MTczOTUzNDYxOCwicGF0aCI6Ii8xMDk2MjUyMzkvMzc0NzA2NzA3LTVlNDIxNDExLTYyMGItNDU0Zi1iNTAzLTVjYmE5YzRmNWYwNC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQxMjAzMzhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1kNTU0MDFjYmE2YmE4ODY5ODk5ZmI5MDAyMGQ2Yzc5Y2U5ZGVlOTkyNmMyYzdhNGFkNjhjYjQwMzMxNWFjNTAwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.iSAn4V1GQ2Vra6t7Tvb6Hc2JWrWKGH_uLctycpNzhgo)
Done Looks Like
The text was updated successfully, but these errors were encountered: