Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Padding to Progress Bar #687

Closed
5 tasks done
joncameron opened this issue Oct 28, 2024 · 2 comments
Closed
5 tasks done

Add Padding to Progress Bar #687

joncameron opened this issue Oct 28, 2024 · 2 comments
Assignees

Comments

@joncameron
Copy link
Contributor

joncameron commented Oct 28, 2024

Description

The progress bar currently extends to the full width of the media player. Padding around the progress bar would provide easier scrubbing around the beginning and ending around recordings: it's difficult to click and interact with playhead when at 00:00 (and some of the playhead is not visible).

Done Looks Like

  • Center align the progress bar (audio player) the top of the control area bar and the player controls
  • 12 pixels of margin or padding to the left and right of the progress bar
  • Text tooltip for current time can continue floating above the player
  • Keep height of the media player the same
  • This design needs to be tested as well with the height and width of Avalon embeds in the wild

Mockup

Screenshot 2024-10-30 at 12 28 38 PM

Current audio player

Screenshot 2024-10-30 at 3 13 09 PM

@elynema
Copy link

elynema commented Nov 6, 2024

I think the new design is looking much improved! Seeing the left/right padding, new size of progress bar, and vertical centering on all devices.

@elynema
Copy link

elynema commented Nov 6, 2024

Dananji reverted this design for the audio player embedded widget because the 2 layer approach was causing a vertical scroll in the embeds. So the embedded audio player has the same design as it used to. Both video and audio are now fitting fine in the embedded environment.

Embedded audio seems to be missing the playback speed and audio quality widgets. Will likely need to create a new issue for that.

@elynema elynema closed this as completed Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants