Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transcripts fix #216

Merged
merged 6 commits into from
Aug 22, 2023
Merged

Transcripts fix #216

merged 6 commits into from
Aug 22, 2023

Conversation

Dananji
Copy link
Collaborator

@Dananji Dananji commented Aug 15, 2023

In this PR;

  • Fix delay in transcript loading when switching between canvases
  • Cache transcript data in Transcript component state to avoid delays when switching between transcripts and canvases (content in the transcript file is requested for initial render for each transcript, and then cached in the state for any re-renders. State is cleared when transcript is unmounted)

@Dananji Dananji marked this pull request as ready for review August 17, 2023 21:37
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good as far as I can tell. I had to learn some React magic to understand what appeared to be duplicate useEffect declarations but I think I understand it now. There was one method that I wasn't able to fully grasp. It would be nice if that was made clearer but technically there isn't any reason to block this PR so I'm going ahead and approving it.

src/services/transcript-parser.js Show resolved Hide resolved
@Dananji Dananji merged commit 630ccd4 into main Aug 22, 2023
@Dananji Dananji deleted the transcripts-fix branch August 22, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants