Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markers firstpass #220

Merged
merged 8 commits into from
Sep 1, 2023
Merged

Markers firstpass #220

merged 8 commits into from
Sep 1, 2023

Conversation

Dananji
Copy link
Collaborator

@Dananji Dananji commented Aug 28, 2023

Markers display:
image

Marker edit form:
image

Marker delete:
image

No markers in Canvas:
image

Closes #212

@Dananji Dananji force-pushed the markers-firstpass branch from 1fe270f to 0934628 Compare August 28, 2023 21:02
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I had a few questions and suggestions but seems close!

src/components/MarkersDisplay/MarkersDisplay.js Outdated Show resolved Hide resolved
src/services/iiif-parser.test.js Outdated Show resolved Hide resolved
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Dananji Dananji merged commit 1cf10c7 into main Sep 1, 2023
@Dananji Dananji deleted the markers-firstpass branch September 1, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ramp component displays playlist markers for current item on playlist page
2 participants