Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make canvas-level items w/o mediafragment into spans instead of buttons #268

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

Dananji
Copy link
Collaborator

@Dananji Dananji commented Oct 16, 2023

Canvas w/o mediafragment information displayed as a span:
image

Canvas with medifragment information displayed as a button;
image

Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but I wonder if it makes sense to rename SectionButton to something else since it can now be a button or a span. Maybe SectionHeading?

src/components/StructuredNavigation/NavUtils/List.test.js Outdated Show resolved Hide resolved
@Dananji
Copy link
Collaborator Author

Dananji commented Oct 18, 2023

This looks good but I wonder if it makes sense to rename SectionButton to something else since it can now be a button or a span. Maybe SectionHeading?

Yes, sounds good! I'll make that change.

@Dananji Dananji requested a review from cjcolvar October 18, 2023 17:40
@Dananji Dananji merged commit 442c16e into main Oct 19, 2023
@Dananji Dananji deleted the canvas-button-remove branch October 19, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants