Fix playback and transcript scroll for mobile/tablet devices #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dananji
force-pushed
the
ipad-playback-fix
branch
from
a6dcf11 to
a10f52d
Compare
Dananji
force-pushed
the
ipad-playback-fix
branch
from
a10f52d to
bcc9d6d
Compare
Dananji
changed the title
cjcolvar
reviewed
Feb 2, 2024
There was a problem hiding this comment.
I like the autoscroll checkbox and think that code looks great!
The changes for mobile/tablet playback seem fairly big given all the changes to events. Would it be hard to separate these into two different PRs? I'm thinking that if we merge them separate it will be easier to isolate or revert the playback changes if needed.
|
Did you mean split the transcript and event handlers into 2 separate PRs? I don't think it would be hard to do. Let me do that real quick. |
Dananji
force-pushed
the
ipad-playback-fix
branch
from
1d1c01b to
971780c
Compare
|
New PR with transcript changes: #371 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #354