Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove HLS caption handling #443

Merged
merged 4 commits into from
Mar 14, 2024
Merged

Remove HLS caption handling #443

merged 4 commits into from
Mar 14, 2024

Conversation

Dananji
Copy link
Collaborator

@Dananji Dananji commented Mar 5, 2024 •
edited
Loading

@Dananji Dananji changed the title [WIP] Remove duplicated caption overlays in iPads Remove HLS caption handling Mar 14, 2024
@Dananji Dananji marked this pull request as ready for review March 14, 2024 14:24
@Dananji
Copy link
Collaborator Author

Dananji commented Mar 14, 2024

Need some more work on the default caption setting

@Dananji Dananji marked this pull request as draft March 14, 2024 15:27
@Dananji Dananji marked this pull request as ready for review March 14, 2024 20:04
masaball
masaball approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@masaball masaball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good

@Dananji Dananji merged commit 370d656 into main Mar 14, 2024
2 checks passed
@Dananji Dananji deleted the hls-caption-investigation branch March 14, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masaball masaball masaball approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dananji @masaball