Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple captions being selected on initial load #455

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

Dananji
Copy link
Collaborator

@Dananji Dananji commented Mar 18, 2024

Related issue: #452

On initial load programmatically select the first available caption only one caption is shown as selected in the captions menu;
Screenshot 2024-03-18 at 12 36 59 PM

Additional CSS fix to captions icon: fixed captions menu shifting down when captions are turned off;

Before:
Screenshot 2024-03-18 at 12 41 02 PM

After:
Screenshot 2024-03-18 at 12 41 26 PM

Copy link
Contributor

@masaball masaball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Dananji Dananji merged commit efbf5b6 into main Mar 19, 2024
2 checks passed
@Dananji Dananji deleted the multi-caption-selection branch March 19, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants