Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slow search by handling timing of updates and cache #571

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Fix slow search by handling timing of updates and cache #571

merged 1 commit into from
Jul 17, 2024

Conversation

Dananji
Copy link
Collaborator

@Dananji Dananji commented Jul 17, 2024 •
edited
Loading

I was able to reduce the UI update time by ~2 seconds (~4 seconds to ~1 second) for search within functionality from the fixes made in this PR.

I think this could be further improved by restricting the updates to props that goes into TranscriptList component with search within, maybe?

cjcolvar
cjcolvar approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell. Nice work speeding things up! 🚀

@Dananji Dananji merged commit 31e1b6e into main Jul 17, 2024
2 checks passed
@Dananji Dananji deleted the slow-search-within branch July 17, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dananji @cjcolvar