Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit time tooltip display offset to playable range width #629

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

Dananji
Copy link
Collaborator

@Dananji Dananji commented Aug 27, 2024

When mouse pointer is hovering over the blocked parts of the progress-bar, the time tool-tip is displayed outside of the progress-bar container.
This PR fixes the alignment of the time tool-tip by limiting the calculated offset to always align tool-tip with the playable range of the media.

Before:
Screenshot 2024-08-27 at 4 03 51 PM

After:

Screenshot 2024-08-27 at 4 05 02 PM

Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks tricky! I don't totally get it but looks fine to me.

@Dananji Dananji merged commit df6d816 into main Aug 29, 2024
2 checks passed
@Dananji Dananji deleted the time-tooltip-offset branch August 29, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants