Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back tracks upon quality selection #720

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Add back tracks upon quality selection #720

merged 3 commits into from
Nov 11, 2024

Conversation

Dananji
Copy link
Collaborator

@Dananji Dananji commented Nov 6, 2024

Related issue: #717

This is a known issue in the quality-selector plugin we are using. The solution in this PR is to add back in the remote text tracks on quality selection.

@Dananji Dananji marked this pull request as draft November 7, 2024 14:27
@Dananji Dananji marked this pull request as ready for review November 7, 2024 19:16
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

src/components/MediaPlayer/VideoJS/VideoJSPlayer.js Outdated Show resolved Hide resolved
@Dananji Dananji merged commit 9201eb6 into main Nov 11, 2024
2 checks passed
@Dananji Dananji deleted the disappearing-captions branch November 11, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants