-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error: The Lint/InvalidCharacterLiteral
cop has been removed since it was never being actually triggered. (obsolete configuration found in /home/ubuntu/valkyrie/valkyrie/vendor/valk_bundle/ruby/2.3.0/gems/bixby-0.3.0/bixby_default.yml, please update it)
#15
Comments
@HackMasterA which version(s) of |
@no-reply oh, that is a good point it effects unreleased rubocop. Valkyrie is pinned to a SHA that was merged to master a few days ago: rubocop/rubocop@178b315 If possible I could remove the value via local override; it seems like I'd have to somehow override the entire file to remove it. Alternatively, it sounds from the error message that removing it now would be fine -- "it was never actually being triggered" |
Yeah, part of the point of the new versioning strategy is to lock support down. RuboCop has been extremely volatile, and we felt the need to insulate users from breaking changes on point releases and limit maintenance scope here.
Yes, but I'm wondering if this requires a new release on the 0.x series? |
It seems like it would make sense to release it as 0.4.0 in case you need to add anything else to the 0.3.0 to support actually-released rubocops. |
But it also seems like it would be fine at 0.3.1 since it is compatible with currently-released rubocops. |
Remove Lint/InvalidCharacterLiteral, fixes #15
Remove Lint/InvalidCharacterLiteral, fixes #15
This unfortunately does appear to abort the rest of the rubocop run and fail the test suite.
The text was updated successfully, but these errors were encountered: