Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: The Lint/InvalidCharacterLiteral cop has been removed since it was never being actually triggered. (obsolete configuration found in /home/ubuntu/valkyrie/valkyrie/vendor/valk_bundle/ruby/2.3.0/gems/bixby-0.3.0/bixby_default.yml, please update it) #15

Closed
hackartisan opened this issue Oct 4, 2017 · 6 comments

Comments

@hackartisan
Copy link
Contributor

This unfortunately does appear to abort the rest of the rubocop run and fail the test suite.

@hackartisan
Copy link
Contributor Author

@no-reply
Copy link

no-reply commented Oct 4, 2017

@HackMasterA which version(s) of rubocop does this effect?

@hackartisan
Copy link
Contributor Author

@no-reply oh, that is a good point it effects unreleased rubocop.

Valkyrie is pinned to a SHA that was merged to master a few days ago: rubocop/rubocop@178b315

If possible I could remove the value via local override; it seems like I'd have to somehow override the entire file to remove it.

Alternatively, it sounds from the error message that removing it now would be fine -- "it was never actually being triggered"

@no-reply
Copy link

no-reply commented Oct 4, 2017

Yeah, part of the point of the new versioning strategy is to lock support down. RuboCop has been extremely volatile, and we felt the need to insulate users from breaking changes on point releases and limit maintenance scope here.

Alternatively, it sounds from the error message that removing it now would be fine -- "it was never actually being triggered"

Yes, but I'm wondering if this requires a new release on the 0.x series?

@hackartisan
Copy link
Contributor Author

It seems like it would make sense to release it as 0.4.0 in case you need to add anything else to the 0.3.0 to support actually-released rubocops.

@hackartisan
Copy link
Contributor Author

But it also seems like it would be fine at 0.3.1 since it is compatible with currently-released rubocops.

no-reply pushed a commit that referenced this issue Oct 4, 2017
Remove Lint/InvalidCharacterLiteral, fixes #15
no-reply pushed a commit that referenced this issue Oct 4, 2017
Remove Lint/InvalidCharacterLiteral, fixes #15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants