Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bixby not compatible with latest Rubocop #6

Closed
tpendragon opened this issue Sep 5, 2017 · 3 comments
Closed

Bixby not compatible with latest Rubocop #6

tpendragon opened this issue Sep 5, 2017 · 3 comments

Comments

@tpendragon
Copy link 

/home/ubuntu/valkyrie/valkyrie/.rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming
/home/ubuntu/valkyrie/valkyrie/vendor/valk_bundle/ruby/2.3.0/gems/bixby-0.2.2/bixby_default.yml: Style/AccessorMethodName has the wrong namespace - should be Naming
/home/ubuntu/valkyrie/valkyrie/vendor/valk_bundle/ruby/2.3.0/gems/bixby-0.2.2/bixby_default.yml: Style/AsciiIdentifiers has the wrong namespace - should be Naming
/home/ubuntu/valkyrie/valkyrie/vendor/valk_bundle/ruby/2.3.0/gems/bixby-0.2.2/bixby_default.yml: Style/ClassAndModuleCamelCase has the wrong namespace - should be Naming
/home/ubuntu/valkyrie/valkyrie/vendor/valk_bundle/ruby/2.3.0/gems/bixby-0.2.2/bixby_default.yml: Style/ConstantName has the wrong namespace - should be Naming
/home/ubuntu/valkyrie/valkyrie/vendor/valk_bundle/ruby/2.3.0/gems/bixby-0.2.2/bixby_default.yml: Style/FileName has the wrong namespace - should be Naming
/home/ubuntu/valkyrie/valkyrie/vendor/valk_bundle/ruby/2.3.0/gems/bixby-0.2.2/bixby_default.yml: Style/MethodName has the wrong namespace - should be Naming
/home/ubuntu/valkyrie/valkyrie/vendor/valk_bundle/ruby/2.3.0/gems/bixby-0.2.2/bixby_default.yml: Style/PredicateName has the wrong namespace - should be Naming
/home/ubuntu/valkyrie/valkyrie/vendor/valk_bundle/ruby/2.3.0/gems/bixby-0.2.2/bixby_default.yml: Style/VariableName has the wrong namespace - should be Naming
/home/ubuntu/valkyrie/valkyrie/vendor/valk_bundle/ruby/2.3.0/gems/bixby-0.2.2/bixby_default.yml: Style/VariableNumber has the wrong namespace - should be Naming
Error: The `Style/OpMethods` cop has been renamed and moved to `Naming/BinaryOperatorParameter`.
(obsolete configuration found in /home/ubuntu/valkyrie/valkyrie/vendor/valk_bundle/ruby/2.3.0/gems/bixby-0.2.2/bixby_default.yml, please update it)

Should we be defining rubocop versions?
@no-reply
Copy link

no-reply commented Oct 2, 2017

Should we be defining rubocop versions?

I'm not sure there's a good way for us to do that. The whole point of the project is to decouple style concerns from RuboCop versions, and until RuboCop goes 1.0, it will be impossible to predict compatibility without just locking to a particular version.

Thoughts?

@no-reply
Copy link

no-reply commented Oct 2, 2017 •
edited
Loading

After some thought, here is the proposal I have in mind for handling the versioning issue:

  • Merge Upgrade for RuboCop 0.50.0 compatibility #8.
  • Lock rubocop and rubocop-rspec versions to <= 0.50.0 and <= 1.18.0
  • Release Bixby v0.3.0 as the final version in the 0.x series.
  • Create a v0.3.x-stable branch and lock rubocop and rubocop-rspec to exact current versions.
  • Resolve all new cops via PRs to master branch.
  • Release 1.0.0 and commit to periodic updates, bumping dependencies and the version number as needed.

@no-reply
Copy link

no-reply commented Oct 3, 2017

Closing this issue with the fix listed above.

no-reply pushed a commit that referenced this issue Oct 3, 2017
Lock versions to rubocop 0.50.0 and rubocop-rspec 1.18.0
40c4d3d 
We are locking the versions of rubocop dependencies for future releases of Bixby
as discussed on #6.

Future releases will add support for forward versions, and bump major versions
when rubocop compatibility breaks.
@no-reply no-reply mentioned this issue Oct 3, 2017
Merged
no-reply pushed a commit that referenced this issue Oct 3, 2017
Update READEME.md to discuss versioning strategy
0c633b8 
This is based on the versioning strategy outlined in:
#6.
@no-reply no-reply mentioned this issue Oct 3, 2017
Merged
@no-reply no-reply closed this as completed Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@no-reply @tpendragon