3.0.0 fixup #39
Merged
3.0.0 fixup #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 10, 2020 09:39
silences a configuration warning.
we routinely use mixins to define controller actions. this rule tries to prohibit that. disable it.
don't try to make existing projects change this. they have already changed all these to match the old enforced style, and the only reason for the change is to "reduce the number of string instances". rubocop/rubocop-rails#141
this seems like a functional change, which we won't want to force on gems. Rubocop provides an `inverse_of: nil` opt-out, but it's probably better just to keep our style guide out of it altogether.
this rule seems heavy-handed to me, proposing skipping it.
bess
approved these changes
Jun 10, 2020
|
this effectively excludes all rules Hyrax violates, except those that can be
these are both harder fixes but are, to my eyes, genuine (and in the case of the first, egregious) violations of good practice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some issues with the style guide i ran into while upgrading Hyrax.